Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn schema framing into a class #1417

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Turn schema framing into a class #1417

merged 1 commit into from
Jan 2, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 2, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 091ec3a Previous: 6667b99 Ratio
JSON_Array_Of_Objects_Unique 359.48140370615533 ns/iter 360.64912257468245 ns/iter 1.00
JSON_Parse_1 23416.900607454594 ns/iter 23653.79438115162 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 54.19939396318635 ns/iter 51.253201128437176 ns/iter 1.06
JSON_Equality_Helm_Chart_Lock 147.79102851700537 ns/iter 142.69416022857365 ns/iter 1.04
Regex_Lower_S_Or_Upper_S_Asterisk 1.7607642484772963 ns/iter 1.6045096805700656 ns/iter 1.10
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7148984442792223 ns/iter 1.5703066726680281 ns/iter 1.09
Regex_Period_Asterisk 1.7182818598076035 ns/iter 1.5748174212463257 ns/iter 1.09
Regex_Group_Period_Asterisk_Group 1.7485371292492178 ns/iter 1.5918576180073154 ns/iter 1.10
Regex_Period_Plus 2.4898915026524464 ns/iter 1.9054647681817847 ns/iter 1.31
Regex_Period 2.7298482828617807 ns/iter 1.992953358258757 ns/iter 1.37
Regex_Caret_Period_Plus_Dollar 2.0730914083300225 ns/iter 1.9959298735298903 ns/iter 1.04
Regex_Caret_Group_Period_Plus_Group_Dollar 2.1758798690682486 ns/iter 2.0724836296927553 ns/iter 1.05
Regex_Caret_Period_Asterisk_Dollar 1.669622409284416 ns/iter 1.788407284719736 ns/iter 0.93
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.8557998959816224 ns/iter 1.666632092376026 ns/iter 1.11
Regex_Caret_X_Hyphen 6.7526206239004685 ns/iter 6.992695347711883 ns/iter 0.97
Regex_Period_Md_Dollar 78.33348079233967 ns/iter 72.75182007613687 ns/iter 1.08
Regex_Caret_Slash_Period_Asterisk 7.124884656422352 ns/iter 6.992363070129627 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 2.438562862917204 ns/iter 2.133512529836628 ns/iter 1.14
Regex_Nested_Backtrack 854.5812427201789 ns/iter 727.012901243631 ns/iter 1.18
Pointer_Object_Traverse 18.741372333513624 ns/iter 14.764054979109073 ns/iter 1.27
Pointer_Object_Try_Traverse 34.945722195650006 ns/iter 31.440202491005927 ns/iter 1.11
Pointer_Push_Back_Pointer_To_Weak_Pointer 189.1783611493904 ns/iter 173.17992659166924 ns/iter 1.09

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 091ec3a Previous: 6667b99 Ratio
JSON_Array_Of_Objects_Unique 439.576925526577 ns/iter 432.54453382903506 ns/iter 1.02
JSON_Parse_1 30552.92243791685 ns/iter 30096.75415053666 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 54.84104381562624 ns/iter 60.736773425408636 ns/iter 0.90
JSON_Equality_Helm_Chart_Lock 149.13945749284179 ns/iter 149.5472496677341 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.1853238775509807 ns/iter 2.2101433633174965 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.18324046431663 ns/iter 2.209297124408009 ns/iter 0.99
Regex_Period_Asterisk 2.19608989177439 ns/iter 2.213277746606503 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 2.1914828322023703 ns/iter 2.2134752954073185 ns/iter 0.99
Regex_Period_Plus 2.487465262922396 ns/iter 2.4883742988004802 ns/iter 1.00
Regex_Period 2.4871183712653813 ns/iter 2.2128603211101323 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 2.489691824921853 ns/iter 2.2173238376929767 ns/iter 1.12
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4919324296640464 ns/iter 2.216469586509374 ns/iter 1.12
Regex_Caret_Period_Asterisk_Dollar 3.422862373823121 ns/iter 2.385101996143657 ns/iter 1.44
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.420138430502598 ns/iter 2.214756944531751 ns/iter 1.54
Regex_Caret_X_Hyphen 12.484842786119046 ns/iter 13.048791104757349 ns/iter 0.96
Regex_Period_Md_Dollar 73.40240868472426 ns/iter 79.1325106869709 ns/iter 0.93
Regex_Caret_Slash_Period_Asterisk 7.1485381714224605 ns/iter 6.221289086708885 ns/iter 1.15
Regex_Caret_Period_Range_Dollar 3.7297699672949487 ns/iter 3.733126920909408 ns/iter 1.00
Regex_Nested_Backtrack 492.91409140271736 ns/iter 500.3022369546572 ns/iter 0.99
Pointer_Object_Traverse 44.953928037682466 ns/iter 44.894431923998305 ns/iter 1.00
Pointer_Object_Try_Traverse 52.305023550296646 ns/iter 52.33582066720902 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 353.01173559168654 ns/iter 380.28636023640075 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 091ec3a Previous: 6667b99 Ratio
Pointer_Object_Traverse 50.602628700005425 ns/iter 44.442655358362416 ns/iter 1.14
Pointer_Object_Try_Traverse 22.4219410618988 ns/iter 23.494253306557223 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.1762118092809 ns/iter 213.10647199887742 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.165242113814663 ns/iter 2.4867689628241503 ns/iter 1.27
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.17295413912689 ns/iter 2.4866296913992514 ns/iter 1.28
Regex_Period_Asterisk 3.210550035227697 ns/iter 2.4900820195803837 ns/iter 1.29
Regex_Group_Period_Asterisk_Group 3.183950508013328 ns/iter 2.500625816047421 ns/iter 1.27
Regex_Period_Plus 3.2621880268994947 ns/iter 2.7996740635189394 ns/iter 1.17
Regex_Period 3.234559022438772 ns/iter 2.798593663171218 ns/iter 1.16
Regex_Caret_Period_Plus_Dollar 3.2138730179220563 ns/iter 2.801115065661819 ns/iter 1.15
Regex_Caret_Group_Period_Plus_Group_Dollar 3.1910334043652773 ns/iter 2.799230646183924 ns/iter 1.14
Regex_Caret_Period_Asterisk_Dollar 3.72988528477373 ns/iter 3.7366498414245948 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.7271767900291266 ns/iter 3.72887042415774 ns/iter 1.00
Regex_Caret_X_Hyphen 12.429915547896773 ns/iter 12.430287154594764 ns/iter 1.00
Regex_Period_Md_Dollar 89.72000806885049 ns/iter 87.76658876557609 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 5.905069532704788 ns/iter 7.1544644729608855 ns/iter 0.83
Regex_Caret_Period_Range_Dollar 3.2082511147914294 ns/iter 4.041553739499392 ns/iter 0.79
Regex_Nested_Backtrack 816.0720425467645 ns/iter 812.0105512761013 ns/iter 1.01
JSON_Array_Of_Objects_Unique 378.1482445819137 ns/iter 379.34210943864036 ns/iter 1.00
JSON_Parse_1 32716.680685653228 ns/iter 32831.962390520355 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 63.599949405387235 ns/iter 62.99960128501887 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 141.62577106773202 ns/iter 145.29841994331204 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 091ec3a Previous: 6667b99 Ratio
JSON_Array_Of_Objects_Unique 420.245932131847 ns/iter 421.4853427908528 ns/iter 1.00
JSON_Parse_1 81956.31445023284 ns/iter 80318.90624999555 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 53.41971428570957 ns/iter 55.53470535714057 ns/iter 0.96
JSON_Equality_Helm_Chart_Lock 216.28112500000185 ns/iter 220.66437500001254 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 8.259186123842827 ns/iter 8.444252640874119 ns/iter 0.98
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.587120943808651 ns/iter 8.19787228483079 ns/iter 1.05
Regex_Period_Asterisk 7.918353794643198 ns/iter 7.775402643859273 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 8.615118303572089 ns/iter 7.902271205357485 ns/iter 1.09
Regex_Period_Plus 8.043388356949883 ns/iter 7.948154428802565 ns/iter 1.01
Regex_Period 8.32117898070863 ns/iter 8.023016741072198 ns/iter 1.04
Regex_Caret_Period_Plus_Dollar 7.906087464704277 ns/iter 8.044575892857914 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 8.100602642407418 ns/iter 8.142361570793573 ns/iter 0.99
Regex_Caret_Period_Asterisk_Dollar 7.930307812500814 ns/iter 8.19105665986122 ns/iter 0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar 8.253850409581005 ns/iter 7.806166036580585 ns/iter 1.06
Regex_Caret_X_Hyphen 11.597089285714901 ns/iter 11.83149107142713 ns/iter 0.98
Regex_Period_Md_Dollar 141.96623473364866 ns/iter 141.68124999999677 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 11.818091071426856 ns/iter 11.874508928571004 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 9.632521831998398 ns/iter 8.771090585844108 ns/iter 1.10
Regex_Nested_Backtrack 588.9904464285881 ns/iter 588.5875892856924 ns/iter 1.00
Pointer_Object_Traverse 56.46356250000142 ns/iter 56.308107142858226 ns/iter 1.00
Pointer_Object_Try_Traverse 76.09699776785257 ns/iter 76.385669642866 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 187.5133828137129 ns/iter 178.0819583536858 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the frame-class branch 4 times, most recently from e4d8155 to 148ad20 Compare January 2, 2025 16:19
@jviotti jviotti marked this pull request as ready for review January 2, 2025 16:20
@jviotti jviotti force-pushed the frame-class branch 4 times, most recently from 204fd5a to d8cae41 Compare January 2, 2025 17:34
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 1a6da6d into main Jan 2, 2025
13 checks passed
@jviotti jviotti deleted the frame-class branch January 2, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant