Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return found identifiers in FlatFileSchemaResolver #1418

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 2, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 6e59fc9 Previous: 1a6da6d Ratio
JSON_Array_Of_Objects_Unique 362.0665332594481 ns/iter 331.70046062786145 ns/iter 1.09
JSON_Parse_1 24144.394243640785 ns/iter 21356.25038047383 ns/iter 1.13
JSON_Fast_Hash_Helm_Chart_Lock 51.92815542057102 ns/iter 47.67208385950813 ns/iter 1.09
JSON_Equality_Helm_Chart_Lock 148.097529232713 ns/iter 139.7911973177559 ns/iter 1.06
Regex_Lower_S_Or_Upper_S_Asterisk 1.7352549021865236 ns/iter 1.5689072916026028 ns/iter 1.11
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7066211539654499 ns/iter 1.5698950122230781 ns/iter 1.09
Regex_Period_Asterisk 1.6784207338500334 ns/iter 1.569736139325377 ns/iter 1.07
Regex_Group_Period_Asterisk_Group 1.699736735320779 ns/iter 1.6620222074223656 ns/iter 1.02
Regex_Period_Plus 2.0179876398484233 ns/iter 1.9008268133158577 ns/iter 1.06
Regex_Period 2.148086013797549 ns/iter 2.0175798981743736 ns/iter 1.06
Regex_Caret_Period_Plus_Dollar 2.2773090244076446 ns/iter 1.9916746586339862 ns/iter 1.14
Regex_Caret_Group_Period_Plus_Group_Dollar 2.0268066546836967 ns/iter 1.9419252366861217 ns/iter 1.04
Regex_Caret_Period_Asterisk_Dollar 1.684457457041721 ns/iter 1.5770659764426913 ns/iter 1.07
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.8208088053733658 ns/iter 1.5838795660592926 ns/iter 1.15
Regex_Caret_X_Hyphen 7.105473823708343 ns/iter 6.299122697654158 ns/iter 1.13
Regex_Period_Md_Dollar 81.36886264465787 ns/iter 67.3311467068579 ns/iter 1.21
Regex_Caret_Slash_Period_Asterisk 6.125047189094523 ns/iter 4.959500037574135 ns/iter 1.24
Regex_Caret_Period_Range_Dollar 2.2189755497768453 ns/iter 2.0530541250228946 ns/iter 1.08
Regex_Nested_Backtrack 788.0260348373587 ns/iter 725.3868097788683 ns/iter 1.09
Pointer_Object_Traverse 15.62738550709207 ns/iter 14.74351217170278 ns/iter 1.06
Pointer_Object_Try_Traverse 34.25354711364293 ns/iter 31.22532167329404 ns/iter 1.10
Pointer_Push_Back_Pointer_To_Weak_Pointer 195.63694886265276 ns/iter 179.24413054067514 ns/iter 1.09

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 6e59fc9 Previous: 1a6da6d Ratio
JSON_Array_Of_Objects_Unique 439.10921108816416 ns/iter 468.2803613892782 ns/iter 0.94
JSON_Parse_1 30067.688408303853 ns/iter 30515.170443650513 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 54.69292461545261 ns/iter 54.85217615197577 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 152.00322952002227 ns/iter 149.5508050587914 ns/iter 1.02
Regex_Lower_S_Or_Upper_S_Asterisk 2.211286753492755 ns/iter 2.3077673764171975 ns/iter 0.96
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.221084332699188 ns/iter 2.206087115235731 ns/iter 1.01
Regex_Period_Asterisk 2.20626136543481 ns/iter 2.4868490753506536 ns/iter 0.89
Regex_Group_Period_Asterisk_Group 2.210527538157203 ns/iter 2.206996362244437 ns/iter 1.00
Regex_Period_Plus 2.4855784931074467 ns/iter 2.7394726219854455 ns/iter 0.91
Regex_Period 2.488208325737465 ns/iter 2.2143949291531553 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 2.485846363338109 ns/iter 2.2252429935574805 ns/iter 1.12
Regex_Caret_Group_Period_Plus_Group_Dollar 2.486710946866208 ns/iter 2.212598342157827 ns/iter 1.12
Regex_Caret_Period_Asterisk_Dollar 3.4164213834467447 ns/iter 2.4846937877842783 ns/iter 1.37
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.422306009803683 ns/iter 2.4899461975856036 ns/iter 1.37
Regex_Caret_X_Hyphen 12.525448284128519 ns/iter 13.052657733382212 ns/iter 0.96
Regex_Period_Md_Dollar 73.72614447384439 ns/iter 75.60887049893493 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 7.145834699760325 ns/iter 7.1455931105507124 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.72831399050304 ns/iter 2.531604194839344 ns/iter 1.47
Regex_Nested_Backtrack 493.33082284245114 ns/iter 488.3848863779664 ns/iter 1.01
Pointer_Object_Traverse 44.894695273219526 ns/iter 44.802587607877044 ns/iter 1.00
Pointer_Object_Try_Traverse 52.29524264683903 ns/iter 52.289761550833944 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.18483475051215 ns/iter 351.80301538353433 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 6e59fc9 Previous: 1a6da6d Ratio
JSON_Array_Of_Objects_Unique 420.81015532093164 ns/iter 425.66380534927515 ns/iter 0.99
JSON_Parse_1 80240.56515334193 ns/iter 80132.55658228703 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 56.46005357143784 ns/iter 55.91961999999739 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 221.42309374999058 ns/iter 215.80234375001336 ns/iter 1.03
Regex_Lower_S_Or_Upper_S_Asterisk 8.139759338661138 ns/iter 8.090458705357152 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.163878348215192 ns/iter 8.245396838191114 ns/iter 0.99
Regex_Period_Asterisk 7.841505580357121 ns/iter 7.862862018470468 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 8.038447731970253 ns/iter 8.009217821387933 ns/iter 1.00
Regex_Period_Plus 8.118838169643032 ns/iter 8.076167410714215 ns/iter 1.01
Regex_Period 8.195978794641892 ns/iter 7.760551304638835 ns/iter 1.06
Regex_Caret_Period_Plus_Dollar 7.987820312499291 ns/iter 8.141049070798179 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 8.215987463321593 ns/iter 8.089856213883994 ns/iter 1.02
Regex_Caret_Period_Asterisk_Dollar 8.191349963432579 ns/iter 7.782944196428332 ns/iter 1.05
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.7863069196431365 ns/iter 7.961560267857643 ns/iter 0.98
Regex_Caret_X_Hyphen 11.696594642856441 ns/iter 11.807637499998691 ns/iter 0.99
Regex_Period_Md_Dollar 141.47742225546233 ns/iter 144.80509174976137 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 12.163203571428687 ns/iter 11.673216071431268 ns/iter 1.04
Regex_Caret_Period_Range_Dollar 8.93279862083535 ns/iter 8.720276562499407 ns/iter 1.02
Regex_Nested_Backtrack 586.4192857143078 ns/iter 587.2159821428065 ns/iter 1.00
Pointer_Object_Traverse 56.14034821429113 ns/iter 55.90580357142423 ns/iter 1.00
Pointer_Object_Try_Traverse 77.65078125000967 ns/iter 75.83641071428409 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 179.43531959245882 ns/iter 183.677453899804 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 6e59fc9 Previous: 1a6da6d Ratio
Pointer_Object_Traverse 45.37327508163526 ns/iter 44.86455005869972 ns/iter 1.01
Pointer_Object_Try_Traverse 22.41109866879512 ns/iter 22.415210210587375 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.42917431869313 ns/iter 213.11336375396135 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.1241730156597587 ns/iter 2.486108021456431 ns/iter 1.26
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1268813493322214 ns/iter 2.511950608042351 ns/iter 1.24
Regex_Period_Asterisk 3.1320760781103596 ns/iter 2.485901145056639 ns/iter 1.26
Regex_Group_Period_Asterisk_Group 3.1280741827525533 ns/iter 2.4866709813680306 ns/iter 1.26
Regex_Period_Plus 3.121865781635221 ns/iter 2.7969910828773945 ns/iter 1.12
Regex_Period 3.1247595722381503 ns/iter 2.7962383806899296 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 3.1534537093547015 ns/iter 2.79607152744862 ns/iter 1.13
Regex_Caret_Group_Period_Plus_Group_Dollar 3.134407535745876 ns/iter 2.7978156981145927 ns/iter 1.12
Regex_Caret_Period_Asterisk_Dollar 3.7289208254924366 ns/iter 3.7275587745924756 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.72922584544409 ns/iter 3.726986101631098 ns/iter 1.00
Regex_Caret_X_Hyphen 12.432561616771057 ns/iter 12.43077442394182 ns/iter 1.00
Regex_Period_Md_Dollar 89.5491488262168 ns/iter 87.85639064810994 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 6.2149660205135895 ns/iter 7.145894410263686 ns/iter 0.87
Regex_Caret_Period_Range_Dollar 4.044873441327412 ns/iter 4.0394574433209085 ns/iter 1.00
Regex_Nested_Backtrack 821.077524131542 ns/iter 824.3263590055949 ns/iter 1.00
JSON_Array_Of_Objects_Unique 379.4469787401867 ns/iter 379.86118606071835 ns/iter 1.00
JSON_Parse_1 33010.88322928231 ns/iter 32792.08818143424 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 62.76411429938158 ns/iter 57.52142642673832 ns/iter 1.09
JSON_Equality_Helm_Chart_Lock 142.86866347706982 ns/iter 144.7349230531583 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 0ee2702 into main Jan 2, 2025
13 checks passed
@jviotti jviotti deleted the flat-resolver-ids branch January 2, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant