-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify re-identification in FlatFileSchemaResolver
#1419
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
e3ebbc7
to
678177e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 678177e | Previous: 0ee2702 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
329.57758186424905 ns/iter |
329.3399675412817 ns/iter |
1.00 |
JSON_Parse_1 |
21287.87303125975 ns/iter |
21331.108962448438 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
48.654813428670636 ns/iter |
47.6737428150219 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
143.61378415151466 ns/iter |
139.6768053677924 ns/iter |
1.03 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.5813191008843035 ns/iter |
1.5722575569765591 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.575890518286354 ns/iter |
1.582799453043848 ns/iter |
1.00 |
Regex_Period_Asterisk |
1.6050879009718368 ns/iter |
1.568358348896553 ns/iter |
1.02 |
Regex_Group_Period_Asterisk_Group |
1.60067077622629 ns/iter |
1.5996479082402022 ns/iter |
1.00 |
Regex_Period_Plus |
1.9099436845110742 ns/iter |
1.8804480212535486 ns/iter |
1.02 |
Regex_Period |
1.8833438999511967 ns/iter |
1.8817914463820697 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
1.8823249916932152 ns/iter |
1.881795528212553 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.930488945383704 ns/iter |
1.8899142909896915 ns/iter |
1.02 |
Regex_Caret_Period_Asterisk_Dollar |
1.6052055838060777 ns/iter |
1.5781496546560836 ns/iter |
1.02 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.5853218757258145 ns/iter |
1.568252014718264 ns/iter |
1.01 |
Regex_Caret_X_Hyphen |
6.276971709146932 ns/iter |
6.266640976532446 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
68.99605963220901 ns/iter |
67.31598397341219 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
5.769649401479091 ns/iter |
5.675730203433021 ns/iter |
1.02 |
Regex_Caret_Period_Range_Dollar |
2.0402391195627216 ns/iter |
2.045919018749621 ns/iter |
1.00 |
Regex_Nested_Backtrack |
748.9399248195782 ns/iter |
725.7982201234566 ns/iter |
1.03 |
Pointer_Object_Traverse |
14.897598698720325 ns/iter |
14.982215928707088 ns/iter |
0.99 |
Pointer_Object_Try_Traverse |
31.894161538760017 ns/iter |
31.245729758369272 ns/iter |
1.02 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
170.30563140904775 ns/iter |
173.15524448316944 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 678177e | Previous: 0ee2702 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
444.41653656538335 ns/iter |
436.1068598848601 ns/iter |
1.02 |
JSON_Parse_1 |
31316.198274705992 ns/iter |
30385.30818181879 ns/iter |
1.03 |
JSON_Fast_Hash_Helm_Chart_Lock |
54.742464696391906 ns/iter |
54.72970862570127 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
155.5703471647893 ns/iter |
152.8059339221768 ns/iter |
1.02 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2068446146672462 ns/iter |
2.2085046243982593 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1946042221613085 ns/iter |
2.2012254438011314 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.206630331708572 ns/iter |
2.209739642343287 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.196246274566104 ns/iter |
2.206649790837174 ns/iter |
1.00 |
Regex_Period_Plus |
2.4883548769601798 ns/iter |
2.485951933329508 ns/iter |
1.00 |
Regex_Period |
2.5050671278533065 ns/iter |
2.4858456165301974 ns/iter |
1.01 |
Regex_Caret_Period_Plus_Dollar |
2.3230171572817917 ns/iter |
2.5575844924030804 ns/iter |
0.91 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.2252596591552316 ns/iter |
2.486701204757242 ns/iter |
0.89 |
Regex_Caret_Period_Asterisk_Dollar |
2.4864173134086465 ns/iter |
3.4166573749092084 ns/iter |
0.73 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.4507764882442653 ns/iter |
3.418363713590149 ns/iter |
0.72 |
Regex_Caret_X_Hyphen |
13.048868211668637 ns/iter |
13.055713407867836 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
75.39775908516825 ns/iter |
73.88040186445984 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
6.22140850943272 ns/iter |
7.1583280847349045 ns/iter |
0.87 |
Regex_Caret_Period_Range_Dollar |
3.7291428722237843 ns/iter |
3.7336458886782435 ns/iter |
1.00 |
Regex_Nested_Backtrack |
499.3176054887776 ns/iter |
526.1650180000288 ns/iter |
0.95 |
Pointer_Object_Traverse |
44.826691097354214 ns/iter |
44.913584244271675 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.496979964970585 ns/iter |
52.26458437586507 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.56787439103226 ns/iter |
353.75580488042766 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 678177e | Previous: 0ee2702 | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
44.58565057468614 ns/iter |
44.50504079016515 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
22.43038119666633 ns/iter |
22.417494019529826 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
213.73128982592786 ns/iter |
213.22300390705652 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.128318487066957 ns/iter |
2.4906270261388075 ns/iter |
1.26 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.1281817837694597 ns/iter |
2.490022624320204 ns/iter |
1.26 |
Regex_Period_Asterisk |
3.1292108593975736 ns/iter |
2.4864105938094556 ns/iter |
1.26 |
Regex_Group_Period_Asterisk_Group |
3.147833289389301 ns/iter |
2.4866702933110525 ns/iter |
1.27 |
Regex_Period_Plus |
3.13092437722163 ns/iter |
2.797278251836247 ns/iter |
1.12 |
Regex_Period |
3.1283855984905253 ns/iter |
2.7996525091256554 ns/iter |
1.12 |
Regex_Caret_Period_Plus_Dollar |
3.132303588764756 ns/iter |
2.7986925692499014 ns/iter |
1.12 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.121041100625813 ns/iter |
2.801076067903381 ns/iter |
1.11 |
Regex_Caret_Period_Asterisk_Dollar |
3.1778167718283714 ns/iter |
3.7312391971259498 ns/iter |
0.85 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.1305929641507864 ns/iter |
3.731268417941913 ns/iter |
0.84 |
Regex_Caret_X_Hyphen |
12.430394567555256 ns/iter |
12.454501450826578 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
89.30795241920022 ns/iter |
89.40363678687169 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.220728745602728 ns/iter |
6.216268469114179 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.039412308079529 ns/iter |
4.046054972115788 ns/iter |
1.00 |
Regex_Nested_Backtrack |
814.5974798137565 ns/iter |
819.3864362820715 ns/iter |
0.99 |
JSON_Array_Of_Objects_Unique |
378.08642024218113 ns/iter |
379.16188403750476 ns/iter |
1.00 |
JSON_Parse_1 |
33113.78342802862 ns/iter |
32968.456030029556 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
63.483234784999496 ns/iter |
62.480263054857446 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
155.84912968018833 ns/iter |
142.35814426007707 ns/iter |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 678177e | Previous: 0ee2702 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
420.7352800256018 ns/iter |
422.988032609757 ns/iter |
0.99 |
JSON_Parse_1 |
80038.34821428412 ns/iter |
82795.66964287507 ns/iter |
0.97 |
JSON_Fast_Hash_Helm_Chart_Lock |
55.23322321429142 ns/iter |
52.26274999999987 ns/iter |
1.06 |
JSON_Equality_Helm_Chart_Lock |
218.16734374997537 ns/iter |
217.9733796905313 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
8.222717374006354 ns/iter |
8.065267857142137 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.778955768843729 ns/iter |
8.071469160397983 ns/iter |
0.96 |
Regex_Period_Asterisk |
7.813037911548848 ns/iter |
7.797773437498988 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
7.841650669643739 ns/iter |
8.532543711907614 ns/iter |
0.92 |
Regex_Period_Plus |
7.796836572335409 ns/iter |
7.77218526785869 ns/iter |
1.00 |
Regex_Period |
7.802938358022579 ns/iter |
7.875200857700548 ns/iter |
0.99 |
Regex_Caret_Period_Plus_Dollar |
7.762133928571454 ns/iter |
8.059985937499903 ns/iter |
0.96 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.075085937501012 ns/iter |
8.140893713657626 ns/iter |
0.99 |
Regex_Caret_Period_Asterisk_Dollar |
8.047101562499595 ns/iter |
7.842504464285074 ns/iter |
1.03 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.893561383929588 ns/iter |
7.924437018195726 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
11.795628571430177 ns/iter |
11.820512500000696 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
141.67779278224634 ns/iter |
143.28877262103305 ns/iter |
0.99 |
Regex_Caret_Slash_Period_Asterisk |
11.617116071428363 ns/iter |
11.663226785714187 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
8.70352656250084 ns/iter |
8.751293749998721 ns/iter |
0.99 |
Regex_Nested_Backtrack |
590.5388392857195 ns/iter |
596.3290178572475 ns/iter |
0.99 |
Pointer_Object_Traverse |
55.957179999995795 ns/iter |
56.14603571428591 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
76.13002232143324 ns/iter |
76.2051116071305 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
179.3585968320693 ns/iter |
183.20076450007684 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com