-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a .reidentify()
method on FlatFileSchemaResolver
#1420
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 563bed9 | Previous: 0ee2702 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
329.1812666860746 ns/iter |
329.3399675412817 ns/iter |
1.00 |
JSON_Parse_1 |
21343.354718354687 ns/iter |
21331.108962448438 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
48.63711136679191 ns/iter |
47.6737428150219 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
137.16102746861503 ns/iter |
139.6768053677924 ns/iter |
0.98 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.5656036360217924 ns/iter |
1.5722575569765591 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.571336222438382 ns/iter |
1.582799453043848 ns/iter |
0.99 |
Regex_Period_Asterisk |
1.6022796573181153 ns/iter |
1.568358348896553 ns/iter |
1.02 |
Regex_Group_Period_Asterisk_Group |
1.5793686249469823 ns/iter |
1.5996479082402022 ns/iter |
0.99 |
Regex_Period_Plus |
1.8887870942318095 ns/iter |
1.8804480212535486 ns/iter |
1.00 |
Regex_Period |
1.883946457678229 ns/iter |
1.8817914463820697 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
1.8902100260168613 ns/iter |
1.881795528212553 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.9001591015592727 ns/iter |
1.8899142909896915 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
1.5881098778482758 ns/iter |
1.5781496546560836 ns/iter |
1.01 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.6088295525238017 ns/iter |
1.568252014718264 ns/iter |
1.03 |
Regex_Caret_X_Hyphen |
6.2816777490636255 ns/iter |
6.266640976532446 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
67.28187259220606 ns/iter |
67.31598397341219 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.1739355863185095 ns/iter |
5.675730203433021 ns/iter |
1.09 |
Regex_Caret_Period_Range_Dollar |
2.03942148609186 ns/iter |
2.045919018749621 ns/iter |
1.00 |
Regex_Nested_Backtrack |
725.3281586109679 ns/iter |
725.7982201234566 ns/iter |
1.00 |
Pointer_Object_Traverse |
14.764263789165854 ns/iter |
14.982215928707088 ns/iter |
0.99 |
Pointer_Object_Try_Traverse |
31.661845260125343 ns/iter |
31.245729758369272 ns/iter |
1.01 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
170.84209762200055 ns/iter |
173.15524448316944 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 563bed9 | Previous: 939dc0c | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
445.9850449947485 ns/iter |
439.43729198195905 ns/iter |
1.01 |
JSON_Parse_1 |
30640.139652741207 ns/iter |
30314.861470919324 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
54.71326374610768 ns/iter |
54.714372682895444 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
150.05336601452933 ns/iter |
151.0873094051099 ns/iter |
0.99 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2142258842633695 ns/iter |
2.4876997012364814 ns/iter |
0.89 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.2068860639515973 ns/iter |
2.2231219648789775 ns/iter |
0.99 |
Regex_Period_Asterisk |
2.209575712563198 ns/iter |
2.2895610733920053 ns/iter |
0.97 |
Regex_Group_Period_Asterisk_Group |
2.1855602914983288 ns/iter |
2.2105928915001707 ns/iter |
0.99 |
Regex_Period_Plus |
2.485970382004596 ns/iter |
2.8003888937184382 ns/iter |
0.89 |
Regex_Period |
2.4865820064106865 ns/iter |
2.4900317790093447 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
2.486053757481331 ns/iter |
2.4904943826462054 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.4889240301042537 ns/iter |
2.4938789227236797 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.418073846888464 ns/iter |
3.4243704638764703 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.417887448565217 ns/iter |
3.4185108689090247 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
13.053838433033281 ns/iter |
13.055032100427397 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
74.1116757391721 ns/iter |
74.79770526953382 ns/iter |
0.99 |
Regex_Caret_Slash_Period_Asterisk |
6.215318287724415 ns/iter |
7.148907404731239 ns/iter |
0.87 |
Regex_Caret_Period_Range_Dollar |
3.730564190769701 ns/iter |
3.7280638081431334 ns/iter |
1.00 |
Regex_Nested_Backtrack |
493.19027963008585 ns/iter |
494.81069192052297 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.79153660268646 ns/iter |
44.908164042966696 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.31690500681405 ns/iter |
52.39832755454307 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.30031447648287 ns/iter |
352.27074595814383 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 563bed9 | Previous: 939dc0c | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
44.50755895642474 ns/iter |
44.57744719182455 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
22.432042511923328 ns/iter |
22.406755812145676 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
213.6480611664566 ns/iter |
213.16837429196704 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.2004862371273277 ns/iter |
2.486542228633366 ns/iter |
1.29 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.1921992767556766 ns/iter |
2.487179966664344 ns/iter |
1.28 |
Regex_Period_Asterisk |
3.184439463972508 ns/iter |
2.519255064357063 ns/iter |
1.26 |
Regex_Group_Period_Asterisk_Group |
3.216604808158821 ns/iter |
2.4963794603743463 ns/iter |
1.29 |
Regex_Period_Plus |
3.223091324593119 ns/iter |
2.802420716718299 ns/iter |
1.15 |
Regex_Period |
3.2198807446222006 ns/iter |
2.813533651951125 ns/iter |
1.14 |
Regex_Caret_Period_Plus_Dollar |
3.2004560675916043 ns/iter |
2.7981272735388214 ns/iter |
1.14 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.216198889438583 ns/iter |
2.799768399801086 ns/iter |
1.15 |
Regex_Caret_Period_Asterisk_Dollar |
3.1553743767586093 ns/iter |
3.7291638387557513 ns/iter |
0.85 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.1826151904568905 ns/iter |
3.7274904304475016 ns/iter |
0.85 |
Regex_Caret_X_Hyphen |
12.425804497320717 ns/iter |
12.431013003903681 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
88.9745578042956 ns/iter |
87.92008855518328 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
7.143901032416512 ns/iter |
7.155016215668425 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.039758628542467 ns/iter |
4.045503578472615 ns/iter |
1.00 |
Regex_Nested_Backtrack |
811.1789199868206 ns/iter |
816.7103453092392 ns/iter |
0.99 |
JSON_Array_Of_Objects_Unique |
385.53666303760133 ns/iter |
381.72590451780735 ns/iter |
1.01 |
JSON_Parse_1 |
32512.675776687567 ns/iter |
32926.812055074304 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
66.57047825380087 ns/iter |
62.787174076302854 ns/iter |
1.06 |
JSON_Equality_Helm_Chart_Lock |
143.11546291932825 ns/iter |
142.95499697299994 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 563bed9 | Previous: 939dc0c | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
414.76271809097324 ns/iter |
414.6764308646799 ns/iter |
1.00 |
JSON_Parse_1 |
81043.21428570316 ns/iter |
81472.12053571147 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
56.75052678571189 ns/iter |
58.118035714289 ns/iter |
0.98 |
JSON_Equality_Helm_Chart_Lock |
220.36774909069823 ns/iter |
218.89637500002834 ns/iter |
1.01 |
Regex_Lower_S_Or_Upper_S_Asterisk |
8.105857142857483 ns/iter |
8.32509103426292 ns/iter |
0.97 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
8.058320312500962 ns/iter |
7.926013357471793 ns/iter |
1.02 |
Regex_Period_Asterisk |
7.998782107148662 ns/iter |
7.8114866071426245 ns/iter |
1.02 |
Regex_Group_Period_Asterisk_Group |
7.783765625000478 ns/iter |
7.770339285714404 ns/iter |
1.00 |
Regex_Period_Plus |
7.920495500355321 ns/iter |
7.836621651785082 ns/iter |
1.01 |
Regex_Period |
7.905953536133785 ns/iter |
8.33912406991506 ns/iter |
0.95 |
Regex_Caret_Period_Plus_Dollar |
7.772398437500629 ns/iter |
7.861262276785805 ns/iter |
0.99 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.073286830357114 ns/iter |
8.103453981681273 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
7.769276785713788 ns/iter |
7.828225411482289 ns/iter |
0.99 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.769895089286192 ns/iter |
8.179553534913751 ns/iter |
0.95 |
Regex_Caret_X_Hyphen |
11.575549999999373 ns/iter |
11.545326785715863 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
144.69689732141688 ns/iter |
142.18623249169315 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
11.641928571429666 ns/iter |
11.77340312499986 ns/iter |
0.99 |
Regex_Caret_Period_Range_Dollar |
8.721828125000997 ns/iter |
8.993442187499312 ns/iter |
0.97 |
Regex_Nested_Backtrack |
598.5708928570992 ns/iter |
593.8126785714815 ns/iter |
1.01 |
Pointer_Object_Traverse |
56.55421428572132 ns/iter |
55.97514285713804 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
76.0643080357123 ns/iter |
76.17542857142367 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
179.33954325935153 ns/iter |
196.66123452403176 ns/iter |
0.91 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com