Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception when re-identifying and $ref overrides ($)id #1421

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 6, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 21b79e8 Previous: 16e66cd Ratio
JSON_Array_Of_Objects_Unique 328.50803148356016 ns/iter 334.78911762452213 ns/iter 0.98
JSON_Parse_1 21252.447402733887 ns/iter 21334.131343576417 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 47.62288749708949 ns/iter 49.16698021640305 ns/iter 0.97
JSON_Equality_Helm_Chart_Lock 140.10560505846954 ns/iter 140.25525054753484 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 1.5962909359603936 ns/iter 1.5671186552599168 ns/iter 1.02
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.57118530415313 ns/iter 1.5789722906608812 ns/iter 1.00
Regex_Period_Asterisk 1.6114506265415045 ns/iter 1.789275723592215 ns/iter 0.90
Regex_Group_Period_Asterisk_Group 1.6660024587824704 ns/iter 1.576536627262247 ns/iter 1.06
Regex_Period_Plus 1.8863313691188166 ns/iter 2.0543490345555355 ns/iter 0.92
Regex_Period 1.9003077590233994 ns/iter 1.8989788051477159 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 1.8859253146744974 ns/iter 1.8993088161357106 ns/iter 0.99
Regex_Caret_Group_Period_Plus_Group_Dollar 1.892864257438117 ns/iter 1.8981785176258545 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 1.5857350909482093 ns/iter 1.5760333282378687 ns/iter 1.01
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.5846909307772683 ns/iter 1.5829595761755584 ns/iter 1.00
Regex_Caret_X_Hyphen 6.44249408755696 ns/iter 6.313721402418762 ns/iter 1.02
Regex_Period_Md_Dollar 68.15060567510196 ns/iter 67.89963623684277 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 5.510728005644691 ns/iter 6.731995979847379 ns/iter 0.82
Regex_Caret_Period_Range_Dollar 2.0410318750289527 ns/iter 2.059469095130364 ns/iter 0.99
Regex_Nested_Backtrack 730.9158800372485 ns/iter 738.7008692913683 ns/iter 0.99
Pointer_Object_Traverse 14.901929567077666 ns/iter 16.909531927793754 ns/iter 0.88
Pointer_Object_Try_Traverse 31.449011897966628 ns/iter 32.4261222750035 ns/iter 0.97
Pointer_Push_Back_Pointer_To_Weak_Pointer 186.03679071248112 ns/iter 174.43094317138178 ns/iter 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 21b79e8 Previous: 16e66cd Ratio
JSON_Array_Of_Objects_Unique 432.27146808252945 ns/iter 447.66520367185745 ns/iter 0.97
JSON_Parse_1 30137.923149946484 ns/iter 30251.57244213812 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 54.69786524957831 ns/iter 54.64601006541843 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 146.5292787999571 ns/iter 149.58393090647078 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 2.2059367686759153 ns/iter 2.200158840817654 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.201545038797251 ns/iter 2.1811356928147183 ns/iter 1.01
Regex_Period_Asterisk 2.339651849227115 ns/iter 2.201214575926632 ns/iter 1.06
Regex_Group_Period_Asterisk_Group 2.1961450719187376 ns/iter 2.216045958713959 ns/iter 0.99
Regex_Period_Plus 2.488088005261825 ns/iter 2.244878844220564 ns/iter 1.11
Regex_Period 2.4892141544395123 ns/iter 2.261169073222483 ns/iter 1.10
Regex_Caret_Period_Plus_Dollar 2.487348383985416 ns/iter 2.2661915249759224 ns/iter 1.10
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4920993702518226 ns/iter 2.2603063315400305 ns/iter 1.10
Regex_Caret_Period_Asterisk_Dollar 3.417927767741523 ns/iter 2.487120680708214 ns/iter 1.37
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4203768161013985 ns/iter 2.4865028776082605 ns/iter 1.38
Regex_Caret_X_Hyphen 13.056982577954793 ns/iter 7.461329389148237 ns/iter 1.75
Regex_Period_Md_Dollar 74.67001154939047 ns/iter 74.11868915665042 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 7.14525163963714 ns/iter 7.145345089989452 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.7271645900643984 ns/iter 3.7244037623666104 ns/iter 1.00
Regex_Nested_Backtrack 495.021800540637 ns/iter 492.89612697866085 ns/iter 1.00
Pointer_Object_Traverse 44.848855783361195 ns/iter 45.650367825891664 ns/iter 0.98
Pointer_Object_Try_Traverse 52.33825636114355 ns/iter 52.21074023036143 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.12595063994337 ns/iter 353.8390478493588 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 21b79e8 Previous: 16e66cd Ratio
JSON_Array_Of_Objects_Unique 418.56268750002806 ns/iter 439.97843125580846 ns/iter 0.95
JSON_Parse_1 80752.25446428596 ns/iter 86810.15133253469 ns/iter 0.93
JSON_Fast_Hash_Helm_Chart_Lock 52.179100000000744 ns/iter 56.89972999999782 ns/iter 0.92
JSON_Equality_Helm_Chart_Lock 219.66134374999058 ns/iter 234.44159374999884 ns/iter 0.94
Regex_Lower_S_Or_Upper_S_Asterisk 8.17296651785807 ns/iter 8.929441031565641 ns/iter 0.92
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.93966335741202 ns/iter 7.929005321745428 ns/iter 1.00
Regex_Period_Asterisk 7.924506661051468 ns/iter 8.067330357142767 ns/iter 0.98
Regex_Group_Period_Asterisk_Group 7.76477005462153 ns/iter 7.84424441964328 ns/iter 0.99
Regex_Period_Plus 7.980479428659168 ns/iter 8.034847731986886 ns/iter 0.99
Regex_Period 8.11823032090041 ns/iter 7.877407366071612 ns/iter 1.03
Regex_Caret_Period_Plus_Dollar 7.765629876046224 ns/iter 8.125233258929095 ns/iter 0.96
Regex_Caret_Group_Period_Plus_Group_Dollar 8.375058444754814 ns/iter 8.186296875000007 ns/iter 1.02
Regex_Caret_Period_Asterisk_Dollar 7.7724486607141525 ns/iter 8.239706473214575 ns/iter 0.94
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.6975133928579105 ns/iter 8.336635677068307 ns/iter 0.92
Regex_Caret_X_Hyphen 11.487939285714788 ns/iter 12.161824499276952 ns/iter 0.94
Regex_Period_Md_Dollar 142.14766106482685 ns/iter 145.74046875000283 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 11.731551562499831 ns/iter 11.535155357143319 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 8.687365139788296 ns/iter 8.703137907574638 ns/iter 1.00
Regex_Nested_Backtrack 593.8302678571412 ns/iter 593.8169642857158 ns/iter 1.00
Pointer_Object_Traverse 56.29488999999239 ns/iter 56.34542857143694 ns/iter 1.00
Pointer_Object_Try_Traverse 75.26638392856911 ns/iter 76.24186383929604 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 172.92691113349738 ns/iter 181.24099651167313 ns/iter 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 21b79e8 Previous: 16e66cd Ratio
Pointer_Object_Traverse 44.238757111820625 ns/iter 46.72869247972302 ns/iter 0.95
Pointer_Object_Try_Traverse 22.45694390918787 ns/iter 22.42281395275975 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.34763261332026 ns/iter 213.1276868115032 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4929793752109 ns/iter 3.124726224897788 ns/iter 0.80
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4873889039902877 ns/iter 3.1340321782658807 ns/iter 0.79
Regex_Period_Asterisk 2.489080891311079 ns/iter 3.1432972943424278 ns/iter 0.79
Regex_Group_Period_Asterisk_Group 2.4882458697766 ns/iter 3.1301289854032373 ns/iter 0.79
Regex_Period_Plus 2.86668389566033 ns/iter 3.1242674036195486 ns/iter 0.92
Regex_Period 2.811839477648921 ns/iter 3.126393244408423 ns/iter 0.90
Regex_Caret_Period_Plus_Dollar 2.803932920751916 ns/iter 3.1261821865256976 ns/iter 0.90
Regex_Caret_Group_Period_Plus_Group_Dollar 2.79755032779801 ns/iter 3.126988682397506 ns/iter 0.89
Regex_Caret_Period_Asterisk_Dollar 3.7295884920854836 ns/iter 3.72920273657548 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.746597372259577 ns/iter 3.589990857045418 ns/iter 1.04
Regex_Caret_X_Hyphen 12.43342322979861 ns/iter 12.43338893722167 ns/iter 1.00
Regex_Period_Md_Dollar 92.15692911842953 ns/iter 89.96237420154176 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 7.15054909551467 ns/iter 6.219499606530663 ns/iter 1.15
Regex_Caret_Period_Range_Dollar 4.044121335785873 ns/iter 3.1732187403859444 ns/iter 1.27
Regex_Nested_Backtrack 841.0089452232666 ns/iter 816.2189365544923 ns/iter 1.03
JSON_Array_Of_Objects_Unique 378.2432181193658 ns/iter 378.6682252693765 ns/iter 1.00
JSON_Parse_1 32777.39658311283 ns/iter 32605.412195353118 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 62.856635639900055 ns/iter 66.7538971245688 ns/iter 0.94
JSON_Equality_Helm_Chart_Lock 147.90501115180172 ns/iter 143.02210425039226 ns/iter 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit b3a208d into main Jan 6, 2025
13 checks passed
@jviotti jviotti deleted the better-error-ref-id branch January 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant