Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a function to turn absolute schema references into relative #1424

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 7, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: a4b7b0a Previous: 30bdbfd Ratio
JSON_Array_Of_Objects_Unique 352.5383381172232 ns/iter 328.5681976816777 ns/iter 1.07
JSON_Parse_1 22889.421440179987 ns/iter 21290.004764232217 ns/iter 1.08
JSON_Fast_Hash_Helm_Chart_Lock 51.44931015642443 ns/iter 47.63555569682142 ns/iter 1.08
JSON_Equality_Helm_Chart_Lock 153.65724599046004 ns/iter 140.6939839185073 ns/iter 1.09
Regex_Lower_S_Or_Upper_S_Asterisk 1.6935259247505785 ns/iter 1.7210000096164468 ns/iter 0.98
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7454986746126617 ns/iter 1.6917191849503839 ns/iter 1.03
Regex_Period_Asterisk 1.73290513144171 ns/iter 1.6213994593405456 ns/iter 1.07
Regex_Group_Period_Asterisk_Group 1.6941413371423235 ns/iter 1.658456141472408 ns/iter 1.02
Regex_Period_Plus 2.0230902629958467 ns/iter 2.066603532281212 ns/iter 0.98
Regex_Period 2.0524880228795235 ns/iter 1.9070880685432858 ns/iter 1.08
Regex_Caret_Period_Plus_Dollar 2.0248272853932843 ns/iter 1.9765349226844413 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 2.0455638625469974 ns/iter 2.04901840075823 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 1.6955373661518245 ns/iter 1.6666231745930804 ns/iter 1.02
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6857900685009286 ns/iter 1.718850463944502 ns/iter 0.98
Regex_Caret_X_Hyphen 6.742399165261734 ns/iter 7.154652071213014 ns/iter 0.94
Regex_Period_Md_Dollar 74.62541028415144 ns/iter 76.25686040415383 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 6.581414121266701 ns/iter 6.692913296943126 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 2.2145113105709266 ns/iter 2.2936350044681584 ns/iter 0.97
Regex_Nested_Backtrack 777.3427604585395 ns/iter 853.4459445368984 ns/iter 0.91
Pointer_Object_Traverse 15.79959293176281 ns/iter 15.561300927368134 ns/iter 1.02
Pointer_Object_Try_Traverse 33.661931484882665 ns/iter 33.83626335739549 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 182.94402190883085 ns/iter 196.3917889036921 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: a4b7b0a Previous: 30bdbfd Ratio
JSON_Array_Of_Objects_Unique 446.4685329306016 ns/iter 444.7029717190713 ns/iter 1.00
JSON_Parse_1 31496.752451195684 ns/iter 30094.860889346444 ns/iter 1.05
JSON_Fast_Hash_Helm_Chart_Lock 54.694890274485175 ns/iter 54.747892524737814 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 150.72785579846015 ns/iter 153.6262297509604 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 2.492501046135892 ns/iter 2.4889765445066074 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.2006309833763082 ns/iter 2.2030498602022406 ns/iter 1.00
Regex_Period_Asterisk 2.4879758749322596 ns/iter 2.395607758053087 ns/iter 1.04
Regex_Group_Period_Asterisk_Group 2.184962536334425 ns/iter 2.205967351655029 ns/iter 0.99
Regex_Period_Plus 2.7982038347622584 ns/iter 2.7992309449809905 ns/iter 1.00
Regex_Period 2.491006414356819 ns/iter 2.4940700463051075 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4970689939997612 ns/iter 2.489684124547867 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4896053760428045 ns/iter 2.4872173738739063 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.4787860190640663 ns/iter 3.4195522694475806 ns/iter 1.02
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.416609979615025 ns/iter 3.4211430125051834 ns/iter 1.00
Regex_Caret_X_Hyphen 12.502212004170419 ns/iter 12.554150853321017 ns/iter 1.00
Regex_Period_Md_Dollar 73.93230697556125 ns/iter 75.48205857211585 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 7.153224928162029 ns/iter 7.146219596969072 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.7323073896286196 ns/iter 3.728600153351832 ns/iter 1.00
Regex_Nested_Backtrack 492.4122443643087 ns/iter 478.1982704156642 ns/iter 1.03
Pointer_Object_Traverse 44.882048098797696 ns/iter 45.35063209246556 ns/iter 0.99
Pointer_Object_Try_Traverse 52.35937714031618 ns/iter 52.2768754337474 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.43602980506336 ns/iter 353.2517207047232 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: a4b7b0a Previous: 30bdbfd Ratio
JSON_Array_Of_Objects_Unique 417.5444858239269 ns/iter 412.4324101592953 ns/iter 1.01
JSON_Parse_1 82920.32366072581 ns/iter 82066.19419642688 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 59.924928571431586 ns/iter 53.192625000002224 ns/iter 1.13
JSON_Equality_Helm_Chart_Lock 216.9914999999989 ns/iter 216.53843676169143 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 8.265776748813057 ns/iter 8.224203125000479 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.8632249648960455 ns/iter 7.925596839618018 ns/iter 0.99
Regex_Period_Asterisk 7.785470982142329 ns/iter 8.00758370535805 ns/iter 0.97
Regex_Group_Period_Asterisk_Group 8.163759338554303 ns/iter 7.792122767856315 ns/iter 1.05
Regex_Period_Plus 7.797179429477697 ns/iter 7.826460937499899 ns/iter 1.00
Regex_Period 8.509804687500479 ns/iter 8.024820312499006 ns/iter 1.06
Regex_Caret_Period_Plus_Dollar 7.828598214285925 ns/iter 22.222493750000183 ns/iter 0.35
Regex_Caret_Group_Period_Plus_Group_Dollar 8.116833445906977 ns/iter 8.137491927956457 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 7.750283482142859 ns/iter 8.022802455356675 ns/iter 0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.875206473214444 ns/iter 7.876944196428022 ns/iter 1.00
Regex_Caret_X_Hyphen 11.72874642857177 ns/iter 11.588416019695972 ns/iter 1.01
Regex_Period_Md_Dollar 142.45358069402187 ns/iter 142.45619230106436 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 11.634739285712824 ns/iter 11.867296428572363 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 8.80984687499975 ns/iter 9.484410937499634 ns/iter 0.93
Regex_Nested_Backtrack 586.4802999999483 ns/iter 590.7661999999618 ns/iter 0.99
Pointer_Object_Traverse 55.99624107142225 ns/iter 56.13882000000104 ns/iter 1.00
Pointer_Object_Try_Traverse 75.87925223214245 ns/iter 76.04763392856334 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 185.27982904282894 ns/iter 174.21511434476056 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: a4b7b0a Previous: 30bdbfd Ratio
Pointer_Object_Traverse 43.89214179312709 ns/iter 44.22095085636131 ns/iter 0.99
Pointer_Object_Try_Traverse 22.437118596323337 ns/iter 22.41523260721051 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.12204565466797 ns/iter 213.4072058434985 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4881097729247252 ns/iter 3.108980096639853 ns/iter 0.80
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4940025102623813 ns/iter 3.1105155801293787 ns/iter 0.80
Regex_Period_Asterisk 2.4994469852790453 ns/iter 3.1101855770313453 ns/iter 0.80
Regex_Group_Period_Asterisk_Group 2.4872902107644497 ns/iter 3.110873547611168 ns/iter 0.80
Regex_Period_Plus 2.799289630097337 ns/iter 3.111067950855304 ns/iter 0.90
Regex_Period 2.832819481484317 ns/iter 3.108902804913187 ns/iter 0.91
Regex_Caret_Period_Plus_Dollar 2.7995153040426266 ns/iter 3.11563015271816 ns/iter 0.90
Regex_Caret_Group_Period_Plus_Group_Dollar 2.797140154822702 ns/iter 3.111105390206694 ns/iter 0.90
Regex_Caret_Period_Asterisk_Dollar 3.7294173540412023 ns/iter 3.7285986733150622 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.7297869139634794 ns/iter 3.728761284842226 ns/iter 1.00
Regex_Caret_X_Hyphen 12.433621708799208 ns/iter 12.432857852561543 ns/iter 1.00
Regex_Period_Md_Dollar 89.24948731994282 ns/iter 93.87506188949625 ns/iter 0.95
Regex_Caret_Slash_Period_Asterisk 7.1484277872054065 ns/iter 7.152496923695065 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.039226735008238 ns/iter 4.043808993874388 ns/iter 1.00
Regex_Nested_Backtrack 824.9331997154923 ns/iter 829.9998964214049 ns/iter 0.99
JSON_Array_Of_Objects_Unique 378.65266833085576 ns/iter 381.31025858999664 ns/iter 0.99
JSON_Parse_1 32822.39336270639 ns/iter 32928.00693695727 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 62.90297135068379 ns/iter 62.82525937865529 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 154.64250284980562 ns/iter 144.1873473920575 ns/iter 1.07

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the relativize branch 2 times, most recently from af4df7a to 0676211 Compare January 7, 2025 15:16
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti changed the title [WIP] Implement a function to turn absolute schema references into relative Implement a function to turn absolute schema references into relative Jan 7, 2025
@jviotti jviotti marked this pull request as ready for review January 7, 2025 15:25
@jviotti jviotti merged commit 08ea8d9 into main Jan 7, 2025
13 checks passed
@jviotti jviotti deleted the relativize branch January 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant