feat: Make Iterator implement Enumerable #45
Conversation
badger/badger.go
Outdated
| return false, err | ||
| } | ||
|
|
||
| if it.valid() && equal(it.i.Item().Key(), it.end) { |
There was a problem hiding this comment.
todo: Re-add the comment back as to why this section is necessary
There was a problem hiding this comment.
I decided against keeping the comment, as this if check is going very soon anyway in #27 as the start (end for reverse) are going to be inclusive.
There was a problem hiding this comment.
Ah no, I got mixed up! This check is in the wrong place and valid/Seek are buggy.
- Change something
There was a problem hiding this comment.
I added the comment back, and expanded it. This line will be moved/removed when fixing badger Seek.
badger/badger.go
Outdated
| return false, err | ||
| } | ||
|
|
||
| if it.valid() && equal(it.i.Item().Key(), it.end) { |
There was a problem hiding this comment.
suggestion: The call to it.valid() is redundant as it.Seek() already calls it and that is what hasValue represents.
There was a problem hiding this comment.
😁 I have a memory of removing that, maybe I reverted it along with a broken change, re-removing is problem free, thanks Fred.
- Remove extra
validcheck
| // We don't need to bother loading the latest item in reverse, as the Last item | ||
| // will be of the latest version anyway. |
namespace/namespace.go
Outdated
| // we can use unsafe here since we already aquired locks | ||
| // either prefix (priority) or start/end |
There was a problem hiding this comment.
todo: This comment can be removed as we no longer use unsafe.
There was a problem hiding this comment.
I don't think we used unsafe at the time we removed the mutexes anyway :)
Nice spot, thanks Fred.
- Remove outdated comment
AndrewSisley
force-pushed
the
41-enumerable-iter
branch
from
ac0a349 to
179a1fb
Compare
Relevant issue(s)
Resolves #41
Description
Makes Iterator implement Enumerable.
Avoids the direct reference from the production code, but enforces implementation in the tests.
Also simplifies the namespace code slightly, a lot got trimmed when making the initial change, and there may have been some extra stuff that could have been done outside of this PR.