Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools(i): Simplify releases #3463

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Feb 18, 2025

Relevant issue(s)

Resolves #3462

Description

This PR simplifies our release builds as discussed in standup.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

goreleaser check
docker build . --file=tools/defradb.containerfile

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the release Related to release cycle label Feb 18, 2025
@nasdf nasdf added this to the DefraDB v0.16 milestone Feb 18, 2025
@nasdf nasdf self-assigned this Feb 18, 2025
@nasdf nasdf requested a review from a team February 18, 2025 20:25
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (4d90e6e) to head (6bdb338).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3463      +/-   ##
===========================================
- Coverage    78.41%   78.30%   -0.11%     
===========================================
  Files          397      397              
  Lines        37571    37571              
===========================================
- Hits         29458    29418      -40     
- Misses        6413     6442      +29     
- Partials      1700     1711      +11     
Flag Coverage Δ
all-tests 78.30% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d90e6e...6bdb338. Read the comment docs.

@nasdf nasdf requested a review from shahzadlone February 19, 2025 17:21
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.goreleaser.yaml Outdated
# A build with telemetry included.
- id: "defradb_telemetry"
# Minimal build with no extras
- id: "defradb_slim"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: You prefer slim to lite?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight preference for lite

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, otherwise all looks good assuming you have tested this?

@nasdf nasdf changed the title feat(i): Simplify releases tools(i): Simplify releases Feb 20, 2025
@nasdf nasdf merged commit 05f9fb1 into sourcenetwork:develop Feb 20, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to release cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify release builds
3 participants