-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools(i): Simplify releases #3463
tools(i): Simplify releases #3463
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3463 +/- ##
===========================================
- Coverage 78.41% 78.30% -0.11%
===========================================
Files 397 397
Lines 37571 37571
===========================================
- Hits 29458 29418 -40
- Misses 6413 6442 +29
- Partials 1700 1711 +11
Flags with carried forward coverage won't be shown. Click here to find out more. see 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.goreleaser.yaml
Outdated
# A build with telemetry included. | ||
- id: "defradb_telemetry" | ||
# Minimal build with no extras | ||
- id: "defradb_slim" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: You prefer slim
to lite
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slight preference for lite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, otherwise all looks good assuming you have tested this?
Relevant issue(s)
Resolves #3462
Description
This PR simplifies our release builds as discussed in standup.
Tasks
How has this been tested?
goreleaser check
docker build . --file=tools/defradb.containerfile
Specify the platform(s) on which this was tested: