Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLVM Flang (flang-new) #7

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Support LLVM Flang (flang-new) #7

merged 6 commits into from
Jun 17, 2024

Conversation

rouson
Copy link
Member

@rouson rouson commented Jun 17, 2024

No description provided.

@rouson rouson requested review from ktras and removed request for ktras June 17, 2024 03:59
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than typo in README that I provided a code suggestion for.
Also, I can confirm that when testing this branch locally, I was also able to build and test successfully with LLVM flang.

Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@rouson I committed the typo fix myself because I am confident you would not object, but feel free to check out the last commit on this branch. I wanted to merge this branch so I could make more changes that build off of these changes that inference-engine can use.

@ktras ktras merged commit 2dbb89e into main Jun 17, 2024
6 checks passed
@ktras ktras deleted the support-llvm-flang branch June 17, 2024 17:39
rouson pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants