Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate EDC0 for known MS8 issues #387

Closed
15 tasks done
Tracked by #391 ...
richardtreier opened this issue Jun 19, 2023 · 7 comments
Closed
15 tasks done
Tracked by #391 ...

Investigate EDC0 for known MS8 issues #387

richardtreier opened this issue Jun 19, 2023 · 7 comments
Assignees
Labels
scope/ce sovity's Open Source Community Edition scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. scope/mds related to MDS status/blocked/needs-refinement solution needs to be refined so that development can continue task/analyze Need for investigation
Milestone

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Jun 19, 2023

Feature Request

Description

There's a few things we waited for EDC 0.1.0 to either validate as fixed, (re-)create as issues or implement workarounds for.

Work Breakdown

  • depends on EDC 0.2.x Migration in edc-extensions #391
  • Check our EDC with Core EDC >0 for the following issues:
    • PosgreSQL error when querying >5k results.
    • N+1 SELECT problem affecting transfer processes (slowdown of >10s / 50 data offers)
      • Seems to be fixed for now. A connector with data offers 1, 50, 80 and 500 all average about 3-4s for transfer processes.
    • N+1 SELECT problem affecting catalog (slowdown of >10s / 50 data offers)
      • Seems to persist. 500 assets take 12s on local machine without DB latency.
      • Core EDC has positioned themselves against this issues in favor of Web-DIDs and the Federated Catalog which would periodically crawl ALL connectors in a data space.
    • No clear quantity structure supported by EDC. EDC is tested with in-memory stores. Moved into initiative https://github.com/sovity/PMO-Software/issues/536
    • Contract Negotiation does not persist asset information at time of negotiation agreement. Moved into issue Consuming Contract Agreements contain no Asset Information #336
    • Possibly breaking changes in persistence that cannot be dealt with, or cannot be easily dealt with with database migrations.
    • Validate Connector ID concept for consistency (see Management API Transfer History endpoint, for example)
    • The MS8 Connector's Contract Negotiations fail in HTTPS-only environments. See EDC Connector Configuration and Contract Negotiation #379
    • Transfer Processes don't get put into the state COMPLETED on the providing side.
    • Investigate an old issue where the number of contract offers grew with numAssets to the power of numContractDefinitions.
    • Data consistency issues. Moved into issue Prevent Broken States by Deletion / Editing edc-ui#462
    • Check EDC 0 Capabilities for tracing (?) logging. Logging has been improved with configurable dev logging. Tracing is used in the EE, but not the CE as of now.
  • Create Issues to either ignore, fix or workaround the above issues.
@richardtreier richardtreier added analyze scope/ce sovity's Open Source Community Edition scope/mds related to MDS scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. labels Jun 19, 2023
@richardtreier richardtreier changed the title Investiage Core EDC 0.1.0 for MS8 issues Investigate Core EDC 0.1.0 for MS8 issues Jun 19, 2023
@richardtreier richardtreier added the kind/bug Something isn't working. The software does not behave as expected or specified. label Jun 19, 2023
@richardtreier
Copy link
Collaborator Author

Findings of @efiege on a local machine (no latency to db):

2 Assets:
Catalog retrieve took milliseconds: 525
Transfer took milliseconds: 2525

51 Assets:
Catalog retrieve took milliseconds: 5855
Transfer took milliseconds: 3013

81 Assets:
Catalog retrieve took milliseconds: 3279
Transfer took milliseconds: 4203

501 Assets:
Catalog retrieve took milliseconds: 12975
Transfer took milliseconds: 3638

@richardtreier richardtreier added status/blocked An issue is blocked by another issue or task task/analyze Need for investigation and removed analyze labels Jun 22, 2023
@richardtreier richardtreier changed the title Investigate Core EDC 0.1.0 for MS8 issues Investigate Core EDC 0.1.x for MS8 issues Jun 30, 2023
@richardtreier richardtreier added this to the EDC 0 milestone Aug 10, 2023
@dcarmen1
Copy link

Hi!

I wanted to ask about the status of the issue [387]. I understand that you're likely handling a multitude of tasks, but I'm curious if there have been any updates or progress made regarding the request.

Thank you for the help.

@richardtreier richardtreier changed the title Investigate Core EDC 0.1.x for MS8 issues Investigate EDC0 for known MS8 issues Aug 10, 2023
@richardtreier
Copy link
Collaborator Author

I wanted to ask about the status of the issue [387]. I understand that you're likely handling a multitude of tasks, but I'm curious if there have been any updates or progress made regarding the request.

Hi, our migration to EDC 0.x is still underway, albeit at a very high priority.

At this point we aren't ready yet to test all of the above points as we are still migrating core functionalities.

If you want to track our progress on our EDC 0.x migration, feel free to check out our issues:

@AbdullahMuk AbdullahMuk removed the kind/bug Something isn't working. The software does not behave as expected or specified. label Nov 6, 2023
@dcarmen1
Copy link

dcarmen1 commented Feb 7, 2024

Hi, regarding the status of issue [387] I'm eager to know if there have been any updates or progress made concerning the request, is the implementation inside of the new connector version?
Thank you

@tmberthold
Copy link
Contributor

Hi, regarding the status of issue [387] I'm eager to know if there have been any updates or progress made concerning the request, is the implementation inside of the new connector version? Thank you

Are you looking for a specific point in this issue? We have migrated to core-edc 0.2.1 in the meanwhile, for example this core-edc version is used in out last CE: https://github.com/sovity/edc-extensions/releases/tag/v7.1.1

@dcarmen1
Copy link

dcarmen1 commented Feb 7, 2024

Yes I was looking for this point: The MS8 Connector's Contract Negotiations fail in HTTPS-only environments

@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
@richardtreier richardtreier added status/blocked/needs-refinement solution needs to be refined so that development can continue and removed clean-backlog requires backlog cleaning labels May 29, 2024
@richardtreier richardtreier removed the status/blocked An issue is blocked by another issue or task label May 29, 2024
@richardtreier
Copy link
Collaborator Author

Issues have been split where appliccable or marked as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/ce sovity's Open Source Community Edition scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. scope/mds related to MDS status/blocked/needs-refinement solution needs to be refined so that development can continue task/analyze Need for investigation
Projects
None yet
Development

No branches or pull requests

5 participants