Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDC 0.2.x Migration in UI + API Wrapper #364

Closed
9 tasks done
richardtreier opened this issue Jul 13, 2023 · 0 comments
Closed
9 tasks done

EDC 0.2.x Migration in UI + API Wrapper #364

richardtreier opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
kind/epic Epic which groups several user stories
Milestone

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Jul 13, 2023

Epic

Description

To migrate the UI to 0.1.x, there are the following things to consider:

  • The new Management API uses JSON-LD. This kind of JSON uses "@" signs etc. and is hard to create a ts model for.
  • For each endpoint there is the choice between:
    • Creating new UI API Wrapper endpoints for each page and each request (preferred, but might take a bit more time during the migration). The new API calls would be type-safe thanks to the API wrapper. JSON-LD would be handled in edc-extensions. We need to migrate everything to the API wrapper so we can have dedicated UI endpoint anyways.
    • Adjusting the broken old management api to handle JSON-LD which might need intermediate layers due to the way the json is built in ways you can't create TS Interfaces with it well. This is only worth it if it considerably would reduce the time to migrate the UI, e.g. if migrating the UI would suddenly only take a single day.
    • These above two points should be decided for each request. In general we could also clean up the generated code and create API services in the UI that are more cleaned up, which would use the Angular HttpClient, e.g for DELETE calls, etc.
    • So either way in the end we should have a cleaned up API model + API services in the UI.

Needs Refinement

  • It is possible that creating API Wrapper endpoints for some endpoints might not be the way to go.

Tasks

  1. efiege richardtreier
  2. 10 of 10
    kind/epic
    SaadEGI
  3. 7 of 7
    kind/epic
    SaadEGI
  4. 5 of 5
    kind/epic
    AnurosePrakash richardtreier
  5. 15 of 15
    kind/epic
    SaadEGI richardtreier
  6. kind/enhancement
    richardtreier
  7. scope/ce scope/ee-basic scope/ee-professional scope/mds status/blocked/needs-refinement task/analyze
    richardtreier
  8. 4 of 6
    status/blocked/needs-product task/documentation
    tmberthold
  9. 0 of 1
    richardtreier
@richardtreier richardtreier added the kind/epic Epic which groups several user stories label Jul 13, 2023
@richardtreier richardtreier changed the title Create 0.1.x Migration Strategy EDC 0.1.x Migration Jul 13, 2023
@richardtreier richardtreier changed the title EDC 0.1.x Migration EDC 0.2.x Migration Aug 1, 2023
@richardtreier richardtreier self-assigned this Aug 1, 2023
@richardtreier richardtreier changed the title EDC 0.2.x Migration EDC 0.2.x Migration in UI + API Wrapper Aug 4, 2023
@SebastianOpriel SebastianOpriel pinned this issue Aug 4, 2023
@richardtreier richardtreier added this to the EDC 0 milestone Aug 9, 2023
@richardtreier richardtreier unpinned this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Epic which groups several user stories
Projects
None yet
Development

No branches or pull requests

2 participants