Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

391 backend UI api wrapper GET & POST & DELETE contract definition endpoint with 02x #466

Conversation

SaadEGI
Copy link
Contributor

@SaadEGI SaadEGI commented Aug 3, 2023

efiege and others added 26 commits August 1, 2023 08:36
@SaadEGI SaadEGI changed the title 391 backend UI api wrapper delete contract definition endpoint with 02x 391 backend UI api wrapper GET & POST & DELETE contract definition endpoint with 02x Aug 3, 2023
@SaadEGI SaadEGI requested a review from efiege August 10, 2023 09:16
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after yesterday's pair programmed code review, this looks really good already! 🎉

Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also pushed one commit, care

Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardtreier richardtreier enabled auto-merge (squash) August 15, 2023 14:45
@richardtreier richardtreier merged commit a3d1f3c into main Aug 15, 2023
12 checks passed
@richardtreier richardtreier deleted the 391-backend-ui-api-wrapper-delete-contract-definition-endpoint-with-02x branch August 15, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants