Skip to content

Commit

Permalink
feat: improve buttons visibility (#536)
Browse files Browse the repository at this point in the history
  • Loading branch information
illfixit authored Nov 10, 2023
1 parent 4aa39ea commit b3d4092
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 25 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ the detailed section referring to by linking pull requests or issues.

#### Patch

- Improved visibility of buttons in "Create New Asset" and "Initiate Transfer"
Dialogs

#### Deployment Migration Notes

- Enterprise Edition only, MDS variants only: New optional config variable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ <h1 mat-dialog-title>Create New Asset</h1>
{{ validationMessages.invalidJsonMessage }}
</mat-error>
</mat-form-field>

<ng-container *ngIf="form.dataAddressType === 'Http'">
<div class="form-section-title">Method</div>

Expand Down Expand Up @@ -225,8 +224,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyMethod; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Method Parameterization
</button>
Expand Down Expand Up @@ -257,8 +256,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyPath; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Path Parameterization
</button>
Expand Down Expand Up @@ -316,17 +315,17 @@ <h1 mat-dialog-title>Create New Asset</h1>
<div class="flex flex-row mb-[10px] space-x-[10px]">
<!-- Add Query Param Button -->
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpQueryParamsAddClick()">
Add {{ form.proxyQueryParams ? 'Default' : '' }} Query Param
</button>

<!-- Toggle Proxy QueryParams Button -->
<!-- Toggle Proxy Query Param Parameterization Button -->
<button
*ngIf="form.datasource.controls.httpProxyQueryParams; let ctrl"
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Query Param
Parameterization
Expand All @@ -345,8 +344,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyBody; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Request Body
Parameterization
Expand All @@ -362,8 +361,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="
form.datasource.controls.httpAuthHeaderType.setValue(
'Vault-Secret'
Expand Down Expand Up @@ -442,7 +441,7 @@ <h1 mat-dialog-title>Create New Asset</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
mat-stroked-button
color="warn"
(click)="
form.datasource.controls.httpAuthHeaderType.setValue('None')
Expand Down Expand Up @@ -492,8 +491,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
<!-- Add Header Button -->
<div class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpHeadersAddClick()">
Add Additional Header
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
*ngIf="form.all.controls.httpAuthHeaderType.value === 'None'"
class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="
form.all.controls.httpAuthHeaderType.setValue('Vault-Secret')
">
Expand Down Expand Up @@ -194,8 +194,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
<!-- Add Header Button -->
<div class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpHeadersAddClick()">
Add Additional Header
</button>
Expand Down Expand Up @@ -302,8 +302,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
<div class="flex flex-row mb-[10px] space-x-[10px]">
<!-- Add Query Param Button -->
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpQueryParamsAddClick()">
Add Custom Query Param
</button>
Expand Down Expand Up @@ -343,8 +343,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Hide' : 'Show' }} Http Datasource Parameterization
Fields
Expand Down

0 comments on commit b3d4092

Please sign in to comment.