Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewing max active consuming contract agreements limit #335

Merged
merged 16 commits into from
Jul 4, 2023
Merged

Viewing max active consuming contract agreements limit #335

merged 16 commits into from
Jul 4, 2023

Conversation

AnurosePrakash
Copy link

@AnurosePrakash AnurosePrakash commented Jun 28, 2023 •
edited
Loading

Pull Request

Enforcing limits on consuming contract agreements for enterprise edition Connectors by adding restriction to UI

How Has This Been Tested?

Mock backend

PR is blocked by

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

@AnurosePrakash AnurosePrakash self-assigned this Jun 28, 2023
richardtreier
richardtreier requested changes Jun 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
fake-backend/json/connectorLimits.json Outdated Show resolved Hide resolved
src/app/core/config/active-feature-set.ts Outdated Show resolved Hide resolved
src/app/core/config/profiles/edc-ui-feature.ts Outdated Show resolved Hide resolved
...-ui/contract-agreement-page/contract-agreement-cards/contract-agreement-cards.component.html Show resolved Hide resolved
...-ui/contract-agreement-page/contract-agreement-cards/contract-agreement-cards.component.html Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Show resolved Hide resolved
richardtreier
richardtreier reviewed Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the non-commercial edition the detail dialog always has the status.

The status should only show iff it's the enterprise edition and a limit is configured.

Edit: 1 sec, rest of the review coming soon

image

richardtreier
richardtreier requested changes Jun 28, 2023
View reviewed changes
src/app/component-library/catalog/asset-detail-dialog/asset-property-grid-group-builder.ts Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
...-ui/contract-agreement-page/contract-agreement-cards/contract-agreement-cards.component.html Outdated Show resolved Hide resolved
src/app/component-library/catalog/asset-detail-dialog/asset-detail-dialog.component.html Outdated Show resolved Hide resolved
...nector-ui/contract-agreement-page/contract-agreement-page/contract-agreement-page.service.ts Outdated Show resolved Hide resolved
richardtreier
richardtreier reviewed Jul 3, 2023
View reviewed changes
src/app/component-library/catalog/asset-detail-dialog/asset-detail-dialog.component.html Outdated Show resolved Hide resolved
src/app/component-library/catalog/asset-detail-dialog/asset-property-grid-group-builder.ts Outdated Show resolved Hide resolved
src/app/component-library/catalog/asset-detail-dialog/asset-property-grid-group-builder.ts Show resolved Hide resolved
src/app/component-library/property-grid/property-grid/property-grid.component.html Outdated Show resolved Hide resolved
src/app/component-library/property-grid/property-grid/property-grid.component.html Outdated Show resolved Hide resolved
src/app/component-library/property-grid/property-grid/property-grid.component.html Outdated Show resolved Hide resolved
src/app/component-library/property-grid/property-grid/property-grid.component.html Outdated Show resolved Hide resolved
...i/contract-agreement-page/contract-agreement-cards/contract-agreement-card-mapped.service.ts Outdated Show resolved Hide resolved
...i/contract-agreement-page/contract-agreement-cards/contract-agreement-card-mapped.service.ts Outdated Show resolved Hide resolved
@richardtreier richardtreier requested review from efiege and removed request for efiege July 4, 2023 13:48
@richardtreier richardtreier merged commit 8fa3680 into main Jul 4, 2023
@richardtreier richardtreier deleted the viewing_Max_active_consuming_contract_agreements_limit branch July 4, 2023 13:49
github-actions bot pushed a commit to truzzt/edc-ui that referenced this pull request Oct 26, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
66bf048 
# 1.0.0-alpha.1 (2023-10-26)

### Bug Fixes

* add timeout to catalog browser requests ([4409c0b](4409c0b))
* Added additional information in Changelog [sovity#24](https://github.com/truzzt/edc-ui/issues/24) ([6edaf73](6edaf73))
* better catalog fetch details icon ([768a905](768a905))
* broker bugfixes for MDS 1.2 ([sovity#463](https://github.com/truzzt/edc-ui/issues/463)) ([7de91f0](7de91f0))
* Build on tag ([94700b9](94700b9))
* Catalog not Displayed when a Single Request to another Connector Fails [sovity#66](https://github.com/truzzt/edc-ui/issues/66) ([6b88a85](6b88a85))
* catchError converts array into Observable ([167b8b8](167b8b8))
* ci environment variable not called with env. prefix. ([2e5e539](2e5e539))
* ci environment variable not called with env. prefix. ([eaf523d](eaf523d))
* closing navbar on pressing escape button ([e2cea25](e2cea25))
* data address built wrongly, prepare release ([sovity#345](https://github.com/truzzt/edc-ui/issues/345)) ([a592ff4](a592ff4))
* disable login polling in broker ui ([sovity#368](https://github.com/truzzt/edc-ui/issues/368)) ([74a91ac](74a91ac))
* Do not build image on main push. Skip creating sha tags on main branch. ([343da0d](343da0d))
* Do not build image on main push. Skip creating sha tags on main branch. ([27ce463](27ce463))
* downgrade zone.js ([cf7098d](cf7098d))
* empty message not centered ([sovity#321](https://github.com/truzzt/edc-ui/issues/321)) ([c960d98](c960d98))
* forkJoin quiting when EMPTY received [sovity#66](https://github.com/truzzt/edc-ui/issues/66) ([6326dfd](6326dfd))
* http parameterization fields inaccessible due to asset property bug ([sovity#347](https://github.com/truzzt/edc-ui/issues/347)) ([0e799e5](0e799e5))
* Increase initial budget for production build ([b256ed0](b256ed0))
* labels of MDS categories and sub-categories. ([sovity#215](https://github.com/truzzt/edc-ui/issues/215)) ([a66fd7c](a66fd7c))
* Logout not working due to OAuth2-Proxy - Keycloak incompatibility [sovity#24](https://github.com/truzzt/edc-ui/issues/24) ([01991c6](01991c6))
* parameterization issues due to parameterization logic in core edc ([sovity#348](https://github.com/truzzt/edc-ui/issues/348)) ([d8ed8ec](d8ed8ec))
* Placeholder URLs missing "/catalog/" path ([sovity#115](https://github.com/truzzt/edc-ui/issues/115)) ([425d977](425d977))
* policy dto after edc extensions model update ([sovity#353](https://github.com/truzzt/edc-ui/issues/353)) ([d45340d](d45340d))
* Removed logout button from menu. ([8e5aafd](8e5aafd))
* Removed logout button from menu. ([8658a28](8658a28))
* Removed logout component. ([c97d621](c97d621))
* removed the unwanted error message on giving the 'Cancel' option… ([sovity#103](https://github.com/truzzt/edc-ui/issues/103)) ([d5adc07](d5adc07))
* removed unused code ([07e83ec](07e83ec))
* removed unused code ([190c4b6](190c4b6))
* rename policy definition uid to id ([sovity#12](https://github.com/truzzt/edc-ui/issues/12)) ([c010511](c010511))
* Renamed policy-ids in milestone 7 edc [sovity#54](https://github.com/truzzt/edc-ui/issues/54) ([9ad803d](9ad803d))
* Select sovity or mds logo depending on theme ([ebde9fd](ebde9fd))
* Setting nginx bind address instead of servername ([ac137f1](ac137f1))
* show policy definition id in deletion dialog ([610c40c](610c40c))
* update Criterion ([#6](#6)) ([ab1b6fd](ab1b6fd))

### Features

* Add Help-Box (Zammad links) [sovity#55](https://github.com/truzzt/edc-ui/issues/55) ([b17ce46](b17ce46))
* add last commit details to .version file ([sovity#80](https://github.com/truzzt/edc-ui/issues/80)) ([6c0400d](6c0400d))
* add license and vulnerability scanner ([sovity#66](https://github.com/truzzt/edc-ui/issues/66)) ([a291c4e](a291c4e))
* added app inizializer service ([0ab81fd](0ab81fd))
* Added ENV for nginx bind and port to keep default behaviour [sovity#66](https://github.com/truzzt/edc-ui/issues/66) ([725ccc5](725ccc5))
* Added field CONNECTOR ORIGINATOR ORGANIZATION in Asset Viewer Card to be fetched from app.config.json ([d563a93](d563a93))
* Added MDS logo ([0d98e43](0d98e43))
* adding details popup in the transfer history ([sovity#263](https://github.com/truzzt/edc-ui/issues/263)) ([518c2d0](518c2d0))
* Adding mds theme ([193cf49](193cf49))
* Adding mds theme ([0a1b31d](0a1b31d))
* Adding the test json files ([4a119ef](4a119ef))
* Change stroked button to raised button and switched the color to primary on multiple places ([e3055fa](e3055fa))
* **ci:** add release and publish jobs ([738947f](738947f))
* copyright footer (broker) ([sovity#302](https://github.com/truzzt/edc-ui/issues/302)) ([bf273cc](bf273cc))
* css minor changes + exchanged sovity for truzzt ([471ef95](471ef95))
* custom 404 page ([sovity#377](https://github.com/truzzt/edc-ui/issues/377)) ([46c86f6](46c86f6))
* init truzzt theme ([3f65958](3f65958))
* introduce optional Catalog API url to config ([c3ec34f](c3ec34f))
* legal notice page (broker server) ([sovity#320](https://github.com/truzzt/edc-ui/issues/320)) ([c9c0a05](c9c0a05))
* Making theme incompatible for sovity and mds in cases of primary and accent tags ([112f4a8](112f4a8))
* max active consuming contract agreements limit ([sovity#335](https://github.com/truzzt/edc-ui/issues/335)) ([8fa3680](8fa3680))
* Merging branch changes of 69 - Adding focus to nav list items on clicking the same ([66f6473](66f6473))
* minor UI improvements ([sovity#266](https://github.com/truzzt/edc-ui/issues/266)) ([c5518f5](c5518f5))
* parameterization of http data sources / data sinks ([sovity#341](https://github.com/truzzt/edc-ui/issues/341)) ([d3ba751](d3ba751))
* Passing multiple catalogUrls for catalogUrl property [sovity#46](https://github.com/truzzt/edc-ui/issues/46) ([8769f77](8769f77))
* Removed text from start page. Made help component background intransparent. ([8299c58](8299c58))
* Renamed button from cancel to close in json-dialogs ([sovity#367](https://github.com/truzzt/edc-ui/issues/367)) ([b318b3f](b318b3f))
* sorting, filters, pagination (broker server catalog) ([sovity#319](https://github.com/truzzt/edc-ui/issues/319)) ([20a79b3](20a79b3))
* Support customizing the NGINX listen address [sovity#42](https://github.com/truzzt/edc-ui/issues/42) ([c607b33](c607b33))

### Reverts

* Revert "test github action" ([6ed2c34](6ed2c34))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

Assignees

@AnurosePrakash AnurosePrakash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnurosePrakash @richardtreier