Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new type-safe Asset in UI && Update UiCriterion #487

Merged

Conversation

SaadEGI
Copy link

@SaadEGI SaadEGI commented Sep 20, 2023

closes #472
updates and closes #394

…m/sovity/edc-ui into 394-use-new-create-contract-definition-endpoint-in-ui

# Conflicts:
#	src/app/core/services/api/edc-api.service.ts
#	src/app/core/services/api/fake-backend/asset-fake-service.ts
#	src/app/core/services/api/fake-backend/data/test-assets.ts
@SaadEGI SaadEGI linked an issue Sep 20, 2023 that may be closed by this pull request
@SaadEGI SaadEGI changed the title 394 use new create contract definition endpoint in UI Use new type-safe Asset in UI && Update UiCriterion Sep 20, 2023
richardtreier
richardtreier previously approved these changes Sep 22, 2023
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardtreier richardtreier merged commit cc84938 into main Sep 22, 2023
11 checks passed
@richardtreier richardtreier deleted the 394-use-new-create-contract-definition-endpoint-in-ui branch September 22, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new type-safe Asset in UI Use new Create Contract Definition Endpoint in UI
2 participants