Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve buttons visibility #536

Merged
merged 15 commits into from
Nov 10, 2023
Merged

feat: improve buttons visibility #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cfc5dab
feat: improve buttons visibility
illfixit Nov 9, 2023
0c420a5
chore: change commentar
illfixit Nov 9, 2023
a99eed3
Merge branch 'main' into 531-fix-button-colors-in-the-mds-variant
illfixit Nov 9, 2023
6f0f62f
chore: append CHANGELOG
illfixit Nov 9, 2023
16cad71
chore: change minor to patch
illfixit Nov 9, 2023
cebd7e1
chore: fix npm security issues
illfixit Nov 9, 2023
f241e4e
chore: fix package jsons
illfixit Nov 9, 2023
f375edc
fix: package + lock json
illfixit Nov 9, 2023
ac2bb3a
fix: add webpack and chart.js to package
illfixit Nov 9, 2023
4b1acd2
Revert "fix: add webpack and chart.js to package"
illfixit Nov 10, 2023
17d368b
Revert "fix: package + lock json"
illfixit Nov 10, 2023
b5fc350
Revert "chore: fix package jsons"
illfixit Nov 10, 2023
9b9b100
Revert "chore: fix npm security issues"
illfixit Nov 10, 2023
93ae8c2
feat: improve buttons visibility in Initiate Transfer Dialog
illfixit Nov 10, 2023
c770642
chore: update CHANGELOG
illfixit Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ the detailed section referring to by linking pull requests or issues.

#### Patch

- Improved visibility of buttons in "Create New Asset" and "Initiate Transfer"
Dialogs

#### Deployment Migration Notes

- Enterprise Edition only, MDS variants only: New optional config variable
Expand Down
33 changes: 16 additions & 17 deletions ...app/routes/connector-ui/asset-page/asset-create-dialog/asset-create-dialog.component.html
View file
Open in desktop
illfixit marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ <h1 mat-dialog-title>Create New Asset</h1>
{{ validationMessages.invalidJsonMessage }}
</mat-error>
</mat-form-field>

<ng-container *ngIf="form.dataAddressType === 'Http'">
<div class="form-section-title">Method</div>

Expand Down Expand Up @@ -225,8 +224,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyMethod; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Method Parameterization
</button>
Expand Down Expand Up @@ -257,8 +256,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyPath; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Path Parameterization
</button>
Expand Down Expand Up @@ -316,17 +315,17 @@ <h1 mat-dialog-title>Create New Asset</h1>
<div class="flex flex-row mb-[10px] space-x-[10px]">
<!-- Add Query Param Button -->
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpQueryParamsAddClick()">
Add {{ form.proxyQueryParams ? 'Default' : '' }} Query Param
</button>

<!-- Toggle Proxy QueryParams Button -->
<!-- Toggle Proxy Query Param Parameterization Button -->
<button
*ngIf="form.datasource.controls.httpProxyQueryParams; let ctrl"
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Query Param
Parameterization
Expand All @@ -345,8 +344,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
*ngIf="form.datasource.controls.httpProxyBody; let ctrl"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Disable' : 'Enable' }} Request Body
Parameterization
Expand All @@ -362,8 +361,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="
form.datasource.controls.httpAuthHeaderType.setValue(
'Vault-Secret'
Expand Down Expand Up @@ -442,7 +441,7 @@ <h1 mat-dialog-title>Create New Asset</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
mat-stroked-button
color="warn"
(click)="
form.datasource.controls.httpAuthHeaderType.setValue('None')
Expand Down Expand Up @@ -492,8 +491,8 @@ <h1 mat-dialog-title>Create New Asset</h1>
<!-- Add Header Button -->
<div class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpHeadersAddClick()">
Add Additional Header
</button>
Expand Down
16 changes: 8 additions & 8 deletions ...page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
*ngIf="form.all.controls.httpAuthHeaderType.value === 'None'"
class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="
form.all.controls.httpAuthHeaderType.setValue('Vault-Secret')
">
Expand Down Expand Up @@ -194,8 +194,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
<!-- Add Header Button -->
<div class="flex flex-row mb-[10px]">
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpHeadersAddClick()">
Add Additional Header
</button>
Expand Down Expand Up @@ -302,8 +302,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
<div class="flex flex-row mb-[10px] space-x-[10px]">
<!-- Add Query Param Button -->
<button
mat-button
color="primary"
mat-stroked-button
color="accent"
(click)="form.onHttpQueryParamsAddClick()">
Add Custom Query Param
</button>
Expand Down Expand Up @@ -343,8 +343,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
"
class="flex flex-row mb-[10px]">
<button
mat-button
[color]="ctrl.value ? 'warn' : 'primary'"
mat-stroked-button
[color]="ctrl.value ? 'warn' : 'accent'"
(click)="ctrl.setValue(!ctrl.value)">
{{ ctrl.value ? 'Hide' : 'Show' }} Http Datasource Parameterization
Fields
Expand Down
Loading