Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cropped contract offer id #838

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Sep 20, 2024

What issues does this PR close?
closes reopened #795 Contract offer ID is missing on catalog browser view page

image

Checklist

@illfixit illfixit linked an issue Sep 20, 2024 that may be closed by this pull request
@illfixit illfixit marked this pull request as ready for review September 20, 2024 06:12
@illfixit illfixit enabled auto-merge (squash) September 20, 2024 06:14
@illfixit illfixit changed the title fix string crop fix: cropped contract offer id Sep 20, 2024
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illfixit illfixit merged commit 2da28cf into main Sep 20, 2024
13 checks passed
@illfixit illfixit deleted the 795-contract-offer-id-is-missing-fix branch September 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract offer ID is missing on catalog browser view page
2 participants