Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: undelete title utils for header #845

Closed
wants to merge 1 commit into from

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Sep 20, 2024

What issues does this PR close?
It's the correct Title instead of "MDS Demo" again

image

Checklist

@illfixit illfixit linked an issue Sep 20, 2024 that may be closed by this pull request
import {filter, map, shareReplay} from 'rxjs/operators';

@Injectable()
export class TitleUtilsService {
Copy link
Collaborator

@richardtreier richardtreier Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a Title Strategy, which is the native feature on how to solve this issue. This is why the class was deleted. So whatever logic you want to restore you should restore there.

@illfixit illfixit closed this Sep 26, 2024
@illfixit illfixit deleted the fix-nav-bar-after-i18n branch September 26, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Title bar in EDC UI after i18n
2 participants