Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid configuration after version upgrade #847

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

kamilczaja
Copy link
Collaborator

@kamilczaja kamilczaja commented Sep 25, 2024

This PR fixes a caching issue wherein the app-config.json was aggressively cached and always loaded from disk cache without validation which caused new deployments on the same URL to use an outdated configuration.

See sovity/authority-portal#325 for more information

Checklist

Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilczaja kamilczaja merged commit 602aaa3 into main Sep 25, 2024
11 of 12 checks passed
@kamilczaja kamilczaja deleted the fix-config-caching branch September 25, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants