Feat: PR 테스트 코드 추가 (#8) #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyeon207
commented
Apr 28, 2022
Comment on lines
+56
to
+62
| List<String> userEmailList = new ArrayList<>(); | ||
|
|
||
| List<UserDTO> userDTOList = usersService.findAll(); | ||
| for (UserDTO userDTO : userDTOList) { | ||
| userEmailList.add(userDTO.getEmail()); | ||
| } | ||
| return userEmailList; |
There was a problem hiding this comment.
여기 stream 을 사용하면 어떨까요 ??
Suggested change
| List<String> userEmailList = new ArrayList<>(); | |
| List<UserDTO> userDTOList = usersService.findAll(); | |
| for (UserDTO userDTO : userDTOList) { | |
| userEmailList.add(userDTO.getEmail()); | |
| } | |
| return userEmailList; | |
| userEmailList.findAll().stream().map(UserDTO::getEmail).collect(Collectors.toList()); |
위처럼 더 가독성이 좋게 사용할 수 있을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 테스트 코드 추가
어떤거어떤거 확인 부탁 드립니다