Skip to content

ci: add tests for php 8.4 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris53897 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: add tests for php 8.4 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
fail-fast: false
steps:
- name: Checkout
Expand All @@ -45,6 +46,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
fail-fast: false
env:
APP_DEBUG: '1' # https://github.com/phpstan/phpstan-symfony/issues/37
Expand Down Expand Up @@ -91,6 +93,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
fail-fast: false
timeout-minutes: 20
steps:
Expand Down
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
},

"require-dev": {
"behat/mink-goutte-driver": "^1.1",
"guzzlehttp/guzzle": "^6.3",
"behat/mink-selenium2-driver": "^1.6",
"atoum/atoum": "^4.0",
"fabpot/goutte": "^3.2",
"phpunit/phpunit": "^9.5",
"atoum/stubs": "^2.6"
"behat/mink-goutte-driver": "^1.3 || ^2.0",
Copy link
Collaborator

@Jean-Beru Jean-Beru Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated. We should use behat/mink-browserkit-drive instead. It should resolve PHPStan errors at the same time.

"guzzlehttp/guzzle": "^6.3 || ^7.0",
"behat/mink-selenium2-driver": "^1.7",
"atoum/atoum": "^4.4",
"fabpot/goutte": "^3.3 || ^4.0",
Copy link
Collaborator

@Jean-Beru Jean-Beru Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated too (see my previous comment about behat/mink-goutte-driver.

"phpunit/phpunit": "^9.6.29",
"atoum/stubs": "^2.7"
},

"autoload": {
Expand Down
Loading