fix: App crash when wrong camera info came from frigate server

sp-engineering · Oct 14, 2024 · 1aad7a6 · 1aad7a6
1 parent 13e06bd
commit 1aad7a6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/firebase.json b/firebase.json
@@ -1,5 +1,5 @@
 {
     "react-native": {
-        "crashlytics_debug_enabled": true
+        "crashlytics_debug_enabled": false
     }
 }
diff --git a/helpers/rest.ts b/helpers/rest.ts
@@ -30,7 +30,11 @@ export const get = async <T>(
         },
       },
     );
+    if (!response.ok) {
+      crashlytics().log(`HTTP/${response.status}: GET ${endpoint}`);
+    }
     if (response.status === 401) {
+      crashlytics().log(`Unauthorized`);
       throw new Error(`Wrong credentials when tried to reach ${endpoint}`);
     }
     return response[json === false ? 'text' : 'json']();

diff --git a/views/menu/menuHelpers.ts b/views/menu/menuHelpers.ts
@@ -1,5 +1,6 @@
 import {useEffect} from 'react';
 import {Navigation, OptionsTopBarButton} from 'react-native-navigation';
+import crashlytics from '@react-native-firebase/crashlytics';
 
 export type MenuId =
   | 'camerasList'
@@ -21,6 +22,7 @@ export const useSelectedMenuItem = (current?: MenuId) => {
 };
 
 export const useMenu = (componentId: string, current?: MenuId) => {
+  crashlytics().log(`View change: ${current}`);
   useSelectedMenuItem(current);
 
   useEffect(() => {

diff --git a/views/settings/Settings.tsx b/views/settings/Settings.tsx
@@ -100,6 +100,7 @@ export const Settings: NavigationFunctionComponent = () => {
 
   const save = useCallback(
     (settings: ISettings) => {
+      crashlytics().log(`Save settings`);
       crashlytics().setCrashlyticsCollectionEnabled(
         settings.app.sendCrashReports,
       );

diff --git a/views/system/CameraInfoChart.tsx b/views/system/CameraInfoChart.tsx
@@ -42,19 +42,19 @@ export const CameraInfoChart: FC<ICameraInfoChartProps> = ({cameraInfos}) => {
     () => [
       {
         data: Object.values(cameraInfos)
-          .map(info => info.ffmpeg.cpu!)
+          .map(info => info.ffmpeg.cpu! || 0)
           .filter(v => v !== undefined),
         svg: {fill: getColor(0)},
       },
       {
         data: Object.values(cameraInfos)
-          .map(info => info.capture.cpu!)
+          .map(info => info.capture.cpu! || 0)
           .filter(v => v !== undefined),
         svg: {fill: getColor(1)},
       },
       {
         data: Object.values(cameraInfos)
-          .map(info => info.detect.cpu!)
+          .map(info => info.detect.cpu! || 0)
           .filter(v => v !== undefined),
         svg: {fill: getColor(2)},
       },