Removed ring implementation completely
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringpackage is used to provide an optimized implementation for sha256 hashing algorithm. However:ringused does not support riscv32 architecture, which prevents it from being used in the ZK programsHence, a straightforward solution is to remove
ringdependency from ethereum_hashes.A long(er)-term solution would likely be to make ring support riscv32 (especially since general support for riscv32 seems to be already added in briansmith/ring#2041 - just not he particular architecture used by SP1)... but this is likely a lot more involving