-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Docker cache mounts for Apt lists #57
Conversation
Thanks for doing this. However, I rebased my branch onto this one and tested it and the build is still taking too much disk space. |
Very odd. we can probably try using the disk space workaround in upstream moveit2. but I don't find I need that on MoveIt Studio, which itself source-builds moveit2.. |
Do we still want this PR? |
I think so, but not urgently |
Can you rebase the branch onto |
8418eb2
to
2131431
Compare
2131431
to
129992a
Compare
haven't seen this one before even though I use this strategy in all my projects.. will poke at it |
2217103
to
11d4ef6
Compare
Revisiting this, it seems like CI passes. This is actually probably ready for review! |
Add a comment to first occurrence in each Dockerfile explaining why this is good, also add a doc in a README (in main docs repo?) |
aa878c6
to
922fb0a
Compare
922fb0a
to
b307544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all fine, we really need to review all these Dockerfiles for a few reasons but that's well out of scope.
I've added
in front of every operation that modifies the Apt lists. This ensures that the Apt lists will not end up in the layers and in the final image, while preserving the lists between operations so it doesn't slow down the build.