fix external profilers crashing when starting the server #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _isUnderProfiler ??= Process.GetCurrentProcess() | ||
| .Modules | ||
| .Cast<ProcessModule>() | ||
| .Any(m => m.ModuleName.Contains("JetBrains") || |
There was a problem hiding this comment.
Don't hardcode these.
|
I'm not sure if there's a better way to check for a profiler, and I can't hardcode in all of them. I guess maybe a custom command line argument? But also seems unnecessarily complex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when launching through external profilers like ANTS or dotTrace in modes other than sampling/timeline, because of ???? we get an invalid handle error when trying to open files that don't exist, causing the entire program to crash
added a check for running under a profiler (yes i hate the nullable bool and scanning modules, but i dont know of a better way to do this) then we always check if the file exists in those cases
normal execution is still fast, we only eat the performance hit when running under these profilers (wont affect timeline though if you attach it later)