-
Notifications
You must be signed in to change notification settings - Fork 4.3k
add map and grid prototypes #31665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add map and grid prototypes #31665
Conversation
how do i prevent all tests from trying to spawn them, they should be abstract but map doesnt count as inheriting it |
The base map prototype that just has all the components that the engine's mapping system adds automatically to all maps should just be an engine prototype. |
notifying you to come back to it. |
putting the important one in EnginePrototypes? |
ping electro lol |
My thought was that there should be a base engine prototype with at least - type: Map
- type: PhysicsMap
- type: GridTree
- type: MovedGrids I.e. MapComponent + all the stuff added in However when I briefly played around with it, IIRC I ran into some component initialization/startup issues, and problems with how map entities are assigned mapIds. I can't remember the actual issue I was having, but apparently fixing it would've conflicted with the map load/save refactor. Its also possible it might've already been fixed since load/save refactor was merged. If no one else gets it working I might try again, but probably not anytime soon. |
About the PR
adds
Map
,MapAtmos
,MapAtmosCold
,MapGrid
,MapGridAnchored
prototypesanchored only used downstream right now but could be useful for station anchor pr
Why / Balance
resolves #30999
Media
shittle works
Requirements
Breaking changes
no
Changelog
no cl no fun