Skip to content

Paid Vending machines part 1#37358

Open
insoPL wants to merge 3 commits intospace-wizards:masterfrom
insoPL:PaidVendomats
Open

Paid Vending machines part 1#37358
insoPL wants to merge 3 commits intospace-wizards:masterfrom
insoPL:PaidVendomats

Conversation

@insoPL
Copy link
Copy Markdown
Contributor

@insoPL insoPL commented May 11, 2025

About the PR

Docs:
space-wizards/docs#457

This PR adds some additional paid tools to YouTool vendomat. You can buy items for your spesos, money from that sell goes into Cargo bank account.

Why / Balance

Spesos are now basically worthless for players. This PR will be one step towards introduction of player economy. It also gives incentives for cargo to actually restock tool vend.

Technical details

It's smaller then it appears. Most of the changes are updated loadouts YMLs

Media

https://youtu.be/o6eb5MFpzsc

updated YouTool loadout an ui:
image

Requirements

Breaking changes

Changelog

🆑

  • add: Added some paid tools in YouTool

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. size/L Denotes a PR that changes 1000-4999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 11, 2025
@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 11, 2025

My old PR got borked for some reason so i reopened it.

@lzk228
Copy link
Copy Markdown
Contributor

lzk228 commented May 12, 2025

did you also work on other proce displaying styles? this one doesn't feel good

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

did you also work on other proce displaying styles? this one doesn't feel good

I can remove the box like this
IMG_20250512_103321_997.jpg

@Winkarst-cpu
Copy link
Copy Markdown
Contributor

did you also work on other proce displaying styles? this one doesn't feel good
I can remove the box like this

Is it me or the text is offset?

@K-Dynamic
Copy link
Copy Markdown
Contributor

It would probably be worth redoing the whole vending machine UI into a grid like the chemvend, which would also reduce how long to scroll down

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

did you also work on other proce displaying styles? this one doesn't feel good
I can remove the box like this

Is it me or the text is offset?

Yeah, it is. It's just a draft.

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

It would probably be worth redoing the whole vending machine UI into a grid like the chemvend, which would also reduce how long to scroll down

Good idea, in part 2 I will need to heavily modify UI to allow dynamic price modification. I can do it then

@TaoNewt
Copy link
Copy Markdown
Contributor

TaoNewt commented May 12, 2025

400 spesos for insulz, oh you know tiders are gonna be begging for money in the halls.

You just inadvertently added beggars, you literally added beggars to ss14

@aristophanivan
Copy link
Copy Markdown

aristophanivan commented May 12, 2025

Please, don’t merge it, it’s rediculous. As I think, we need to separate crew’s own money from cargo’s spesos by giving them special component or tag. So crewmen will be able to earn money by receiving salary or by trading with other crewmen.
It’s no use making something paid by cargo spesos, because cargo can create a lot of spesos in some minutes, which makes useless any type of paid stuff

@TaoNewt
Copy link
Copy Markdown
Contributor

TaoNewt commented May 12, 2025

It's been needed for a long time but will be necessary after this, 'electronic tampering' should be a minor crime. Tiders can freely hack vending machines and screw with non department doors, but post this pr, it's going to have bigger consequences.

@aristophanivan
Copy link
Copy Markdown

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines. Just look at some ru-SS14 builds with economy, there are a lot of code to write to make it appropriate. This type of economy (in this pr I mean) is awful and useless. I can say this, because I am a developer of the server with economy and I know how it must work to be appropriate.

@TaoNewt
Copy link
Copy Markdown
Contributor

TaoNewt commented May 12, 2025

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines.

There is a design doc pr draft (that this is part of) that goes over everything planned. Ima edit this in a sec to link it
https://github.com/space-wizards/docs/pull/457/files
On my phone do that took a sec sry

@aristophanivan
Copy link
Copy Markdown

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines.

There is a design doc and bigger pr draft (that this is part of) that goes over everything planned. Ima edit this in a sec to link it

hm, I am waiting, you have intrigued me

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines.

There is a design doc and bigger pr draft (that this is part of) that goes over everything planned. Ima edit this in a sec to link it

hm, I am waiting, you have intrigued me

There is link to design doc at the beginning of the PR description. I don't really see the benefit of splitting currency into two types. But feel free to write some more about it there explaining how(an why) the system works on your fork.

@aristophanivan
Copy link
Copy Markdown

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines.

There is a design doc pr draft (that this is part of) that goes over everything planned. Ima edit this in a sec to link it https://github.com/space-wizards/docs/pull/457/files On my phone do that took a sec sry

hm, as I see, it's something like "in-round" economy, not for "permanent" using by yourself.... looks interesting, but I don't like this type of economy, though.

@TaoNewt
Copy link
Copy Markdown
Contributor

TaoNewt commented May 12, 2025

hm, as I see, it's something like "in-round" economy, not for "permanent" using by yourself.... looks interesting, but I don't like this type of economy, though.

When you say 'type' are you referring to prefering round to round persistent bank ballance?

@aristophanivan
Copy link
Copy Markdown

aristophanivan commented May 12, 2025

I think, that economy update needs to be much bigger than just adding some paid stuff in vending machines.

There is a design doc and bigger pr draft (that this is part of) that goes over everything planned. Ima edit this in a sec to link it

hm, I am waiting, you have intrigued me

There is link to design doc at the beginning of the PR description. I don't really see the benefit of splitting currency into two types. But feel free to write some more about it there explaining how(an why) the system works on your fork.

hm, let me try to explain...
so, your character every round after manifest gets salary (also during round the character gets a kind of bonus to his salary: as I remember, 10% of his round salary), which doesn't have any components. Cargo spesos have BankSecureCash component, which "prohibits" using them in ATMs. Your own cash from your bank account (cash without component) can be used everywhere, while cargo spesos can be used only in cargo.
All your balance stores in component and synchronizes with database. You can use cash from your bank account in any round you want.
UPD: I forgot, you can use your own money in vending machines, but you can not use cargo spesos there.

@aristophanivan
Copy link
Copy Markdown

hm, as I see, it's something like "in-round" economy, not for "permanent" using by yourself.... looks interesting, but I don't like this type of economy, though.

When you say 'type' are you referring to prefering round to round persistent bank ballance?

I don't understand what round-to-round means, but I have meant that I prefer economy, where you can use your cash in any round you want. This type is named by myself "permanent" economy.

@K-Dynamic
Copy link
Copy Markdown
Contributor

400 spesos for insulz, oh you know tiders are gonna be begging for money in the halls.

You just inadvertently added beggars, you literally added beggars to ss14

Tiders better get a job then

@TaoNewt
Copy link
Copy Markdown
Contributor

TaoNewt commented May 12, 2025

400 spesos for insulz, oh you know tiders are gonna be begging for money in the halls.
You just inadvertently added beggars, you literally added beggars to ss14

Tiders better get a job then

No. They musy play harmonica outside of med and shake a can for donations.
"please mam, I just need cash for insulz, please"

@SlimmSlamm

This comment was marked as off-topic.

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

I'd like to see personal bank accounts and stuff like this in the future but as of now you can't really do this without adding pay stubs like SS13 has. I'd love to have gambling, lottery tickets, and, bank accounts and such ported over from Goon to here but we need job based pay stubs first and bank accounts imo

I don't play on goob, what is the point of ATMs and bank accounts? Cash is fun. You can steal it, you can throw it, it's more roleplayable.
I was thinking about pay check system where Command members paying in person members of their staff. Sounds like kind of a fun interaction.

@SlimmSlamm

This comment was marked as off-topic.

@Errant-4 Errant-4 added the P3: Standard Priority: Default priority for repository items. label May 12, 2025
@Errant-4 Errant-4 added T: New Feature Type: New feature or content, or extending existing content D1: High Difficulty: Extensive codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. A: General Interactions Area: General in-game interactions that don't relate to another area. labels May 12, 2025
@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 12, 2025

image
New UI

@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 14, 2025

image
Someone on discord pointed out $ should be on left side of the price.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 20, 2025
@insoPL
Copy link
Copy Markdown
Contributor Author

insoPL commented May 20, 2025

Ths pr will get a lot of mege conflicts from the vend loudouts. I will resolve them when maitainers decide it's time to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. D1: High Difficulty: Extensive codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants