fix: remove timeout from post http request #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
approved these changes
May 7, 2025
stuarttimwhite
force-pushed
the
fix/remove-timeout-from-post-http-request
branch
from
d3bfc46 to
41be121
Compare
stuarttimwhite
force-pushed
the
fix/remove-timeout-from-post-http-request
branch
from
41be121 to
d56a6b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The way the logic is currently written, any http request that takes longer than 3 seconds will be aborted. This is not desirable, for obvious reasons.
What changes are included in this PR?
Removal of the timeout
Are these changes tested?
Kind of. There's examples that use this code.