Skip to content

(Another) 1.6 Magic Update #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

Ajohn10
Copy link

@Ajohn10 Ajohn10 commented Mar 31, 2024

I know this mod is deprecated, but this should fix a large number of the issues in pushing it to 1.6. It's not fully functional due to an issue that still exists in the leveling up screen, which is outside of the Magic mod itself (in SpaceCore's custom skills).

As for the build issues, are you using a preview version for C#? I've never seen the way these variables are being initialized, it's more similar to Javascript. My C# was yelling at me, so I fixed them.

Looks like #413 and #425 beat me to it, but here's another lol

AdamBrownMFG and others added 2 commits March 30, 2024 23:00
…om skill leveling still, outside of this mod). Fixed building issues in JsonAssets and SpaceCore
@Ajohn10
Copy link
Author

Ajohn10 commented Mar 31, 2024

Testing I verified:

-Magician event worked. I also added a small change from a different pull request that improved it for Stardew Valley Expanded.
-Learning spells worked
-Consuming Magic Elixir worked (learning the recipe is part of the JsonAssets issue being fixed)
-Using Travel Core in Teleport spell worked
-Buff worked, Haste is built the same way so should work
-Tilling / Watering / Debris spells worked

@Pet-Slime
Copy link
Contributor

Does this include the #379 fix?

@Ajohn10
Copy link
Author

Ajohn10 commented Apr 3, 2024 via email

@Pet-Slime
Copy link
Contributor

Most likely should since it's a bug that happens on multiplayer playthroughs. I had that happen to my friend group before. Only the first person who had unlocked magic had the proper level. Everyone else would just go to their level.

@Dragonfabri
Copy link

Need some funding to have the mod ready for 1.6? I'd gladly pay a commission to see this mod up and running faster!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants