Notification when an update is available#238
Open
shubham4443 wants to merge 5 commits intospacecloud-io:v0.22.0-oldfrom
Open
Notification when an update is available#238shubham4443 wants to merge 5 commits intospacecloud-io:v0.22.0-oldfrom
shubham4443 wants to merge 5 commits intospacecloud-io:v0.22.0-oldfrom
Conversation
Contributor
|
Contributor
Author
Are you sure the design is correct? The UI version seems to overlap the upgrade box when there is an update available. |
Contributor
|
src/components/sidenav/Sidenav.jsx
Outdated
| @@ -120,7 +120,7 @@ const Sidenav = (props) => { | |||
| </Link> | |||
| </div> | |||
| {isUpdateAvailable ? <React.Fragment> | |||
Contributor
There was a problem hiding this comment.
no need for ternary operator
{isUpdateAvailable && ...updateDiv}
< div >
< popover >...ui version</ popover >
...sc version
< /div >
| {isUpdateAvailable ? <React.Fragment> | ||
| <div style={{ backgroundColor: "#D2E0FF", padding: 16}}> | ||
| <div style={{ backgroundColor: "#D2E0FF", padding: 16 }}> | ||
| Upgrade to v{scLatestVersion} <Button type="primary" ghost style={{ marginLeft: 9 }}>Update</Button> |
Contributor
There was a problem hiding this comment.
what happens onClick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification in the sidenav when there is a spacecloud update available.