Skip to content

[SCSB-155] build with Numpy 2.0 release candidate #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-155

Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as 1.26

this PR pins numpy>=2.0.0rc2 in build-system.requires

Note

this PR was generated automatically by batchpr 🤖

@zacharyburnett zacharyburnett self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (8eb63d1) to head (2fd3746).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   87.64%   86.75%   -0.89%     
==========================================
  Files          17       17              
  Lines        1392     1367      -25     
==========================================
- Hits         1220     1186      -34     
- Misses        172      181       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title pin numpy>=2.0.0rc2 in build-system.requires [SCSB-155] build with Numpy 2.0 release candidate May 31, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review June 4, 2024 14:20
@zacharyburnett zacharyburnett requested a review from a team as a code owner June 4, 2024 14:20
Copy link
Contributor

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit 16f02ce into spacetelescope:master Jun 4, 2024
13 of 14 checks passed
@zacharyburnett zacharyburnett deleted the pin_numpy_build_requirement branch June 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants