Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more regtests #247

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

stscirij
Copy link
Contributor

No description provided.

@stscirij stscirij requested a review from a team as a code owner August 27, 2024 13:48
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 168 lines in your changes missing coverage. Please review.

Project coverage is 79.09%. Comparing base (8eb63d1) to head (ed3c2a5).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_nuv_sci_g185m.py 31.81% 15 Missing ⚠️
tests/test_nuv_sci_g230l.py 31.81% 15 Missing ⚠️
tests/test_nuv_sci_g285m.py 31.81% 15 Missing ⚠️
tests/test_acq_image.py 38.88% 11 Missing ⚠️
tests/test_wavecal_fuvb_g160m.py 38.88% 11 Missing ⚠️
tests/test_wavecal_fuvb_g160m_relmvreq.py 38.88% 11 Missing ⚠️
tests/test_wavecal_nuv_g185m.py 38.88% 11 Missing ⚠️
tests/test_wavecal_nuv_g225m.py 38.88% 11 Missing ⚠️
tests/test_wavecal_nuv_g230l.py 38.88% 11 Missing ⚠️
tests/test_wavecal_nuv_g285m.py 38.88% 11 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   87.64%   79.09%   -8.55%     
==========================================
  Files          17       34      +17     
  Lines        1392     1612     +220     
==========================================
+ Hits         1220     1275      +55     
- Misses        172      337     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stscirij stscirij requested review from stenhasselquist, zacharyburnett and nden and removed request for nden August 27, 2024 15:12
@zacharyburnett
Copy link
Collaborator

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stscirij stscirij merged commit c512a57 into spacetelescope:master Aug 28, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants