Add unit tests that use gwcs. Fix how the bounding box is handled. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcara
changed the title
nden
reviewed
Jan 7, 2025
drizzle/utils.py
Outdated
| @@ -61,6 +61,8 @@ def calc_pixmap(wcs_from, wcs_to, shape=None): | |||
| shape = wcs_from.array_shape | |||
| if shape is None: | |||
| if (bbox := getattr(wcs_from, "bounding_box", None)) is not None: | |||
| if not isinstance(bbox, tuple): | |||
| bbox = bbox.bounding_box() | |||
There was a problem hiding this comment.
This will work only if bounding_box is an instance of modeling.bounding_box.ModelBoundingBox, so a better check is that it is that instance.
nden
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 97.27% 97.32% +0.04%
==========================================
Files 3 3
Lines 220 224 +4
==========================================
+ Hits 214 218 +4
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests that utilize
gwcsin addition to FITS WCS.