-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and deploy dormant DrizzlePac notebook "use_ds9_regions_in_tweakreg.ipynb" #126
Conversation
…auphin/hst_notebooks into add_wfc3_persistence_notebook
…m "exclude patterns" list; use_ds9_regions_in_tweakreg.ipynb: added single space in first markdown cell so that CI/CD tests would trigger.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…n_tweakreg_nb # Conflicts: # notebooks/DrizzlePac/use_ds9_regions_in_tweakreg/use_ds9_regions_in_tweakreg.ipynb # notebooks/WFC3/persistence/wfc3_ir_persistence.ipynb
@camipacifici @haticekaratay @dulude All checks have been passed and are ready for your review 👍🏾 |
View / edit / reply to this conversation on ReviewNB haticekaratay commented on 2023-12-21T14:30:21Z A link to initialization notebook can be added for an easy navigation |
View / edit / reply to this conversation on ReviewNB haticekaratay commented on 2023-12-21T14:30:21Z The current link to the |
View / edit / reply to this conversation on ReviewNB haticekaratay commented on 2023-12-21T14:30:22Z Blue apertures are not visible on the plot. |
@FDauphin , |
@haticekaratay Thanks for looking at this and apologies for the delay. I can't see the comments that were made. Should I just push the notebook with empty cells? |
You can access the comments that were left on the ReviewNB from this |
@haticekaratay Also are the WFC3 IR persistence commits going to overwrite #109? If so, how can we prevent that here? |
@haticekaratay All comments have been addressed and all checks have been passed 👍🏾 |
I will revert changes made to the ir_persistence notebook and sync it with the main, as many merge commits are making it challenging to rebase, especially with notebooks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. All looks good now.
Relevant Ticket
High-Level Summary
Summary of Changes
This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.