Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new STIS notebook Low_Count_Uncertainties.ipynb #288

Merged
merged 14 commits into from
Oct 22, 2024

Conversation

Jackie-Brown
Copy link
Contributor

Added STIS notebook Low_Count_Uncertainties.ipynb, requirements.txt, and pre-requirements.sh

@Jackie-Brown Jackie-Brown added Technical Review Notebook is ready for technical review STIS Space Telescope Imaging Spectrograph labels Jun 26, 2024
@Jackie-Brown Jackie-Brown self-assigned this Jun 26, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Jackie-Brown Jackie-Brown added Technical Review Notebook is ready for technical review and removed Technical Review Notebook is ready for technical review labels Jul 3, 2024
@haticekaratay
Copy link
Collaborator

@Jackie-Brown ,
I ran this notebook locally and encountered the same error as reported on the CI.
image

image

@haticekaratay
Copy link
Collaborator

@Jackie-Brown , another important thing to note is that we are getting a deprecation warning for these two. The notebook will fail when new releases are out.

UserWarning: GFIT is deprecated - stsci.tools v 3.4.12 is the last version to contain it.Use astropy.modeling instead.
  warnings.warn("GFIT is deprecated - stsci.tools v 3.4.12 is the last version to contain it."
UserWarning: NMPFIT is deprecated - stsci.tools v 3.5 is the last version to contain it.
  warnings.warn("NMPFIT is deprecated - stsci.tools v 3.5 is the last version to contain it.")

@sean-lockwood
Copy link
Member

The notebook is calling crds in the Unix shell, but that package is not in the requirements file:

!crds bestrefs --update-bestrefs --sync-references=1 --files ./mastDownload/HST/obgh07020/obgh07020_raw.fits

I believe the Unix call is silently failing because the crds executable cannot be found.

@Jackie-Brown
Copy link
Contributor Author

@haticekaratay I took a look at the depreciation warning for NMPFIT and GFIT, and the notebook doesn't use either of these. Will the notebook still fail when the new version of stsci.tools is out? Otherwise the notebook looks ready to publish unless you have any other concerns

@haticekaratay
Copy link
Collaborator

@haticekaratay I took a look at the depreciation warning for NMPFIT and GFIT, and the notebook doesn't use either of these. Will the notebook still fail when the new version of stsci.tools is out? Otherwise the notebook looks ready to publish unless you have any other concerns

@Jackie-Brown, I will take a look, as it's been a while, and submit my review here this week.

@sean-lockwood
Copy link
Member

@Jackie-Brown @haticekaratay -
Those are known deprecation warnings when importing stistools for now.

@haticekaratay haticekaratay merged commit 45e4ae4 into main Oct 22, 2024
6 checks passed
@haticekaratay haticekaratay deleted the add_low_count_notebook branch October 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STIS Space Telescope Imaging Spectrograph Technical Review Notebook is ready for technical review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants