-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new STIS notebook Low_Count_Uncertainties.ipynb #288
Conversation
…and pre-requirements.sh
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Jackie-Brown , |
@Jackie-Brown , another important thing to note is that we are getting a deprecation warning for these two. The notebook will fail when new releases are out.
|
The notebook is calling !crds bestrefs --update-bestrefs --sync-references=1 --files ./mastDownload/HST/obgh07020/obgh07020_raw.fits I believe the Unix call is silently failing because the |
@haticekaratay I took a look at the depreciation warning for NMPFIT and GFIT, and the notebook doesn't use either of these. Will the notebook still fail when the new version of stsci.tools is out? Otherwise the notebook looks ready to publish unless you have any other concerns |
@Jackie-Brown, I will take a look, as it's been a while, and submit my review here this week. |
@Jackie-Brown @haticekaratay - |
Added STIS notebook Low_Count_Uncertainties.ipynb, requirements.txt, and pre-requirements.sh