-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wfc3 notebook dependencies #299
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for working on this 🙌🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's just one more pre-requirements file to update
@@ -14,7 +14,7 @@ | |||
"\n", | |||
"By the end of this tutorial, you will:\n", | |||
"\n", | |||
"- Download a raw WFC3 image from MAST.\n", | |||
"- Download a raw WFC3 image from MAST. \n", | |||
"- Find the necessary reference files needed for calibration.\n", | |||
"- Edit header keywords.\n", | |||
"- Run `calwf3` `v3.5.2` to calibrate the raw image with the v1.0 pixel based CTE-correction.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instructions need updating for only using hstcal 2.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait! my bad, it's been a minute and I forgot calXXX versions don't track hstcal. I see hstcal 2.5 tracking calwf3 at v3.5.2
This PR is to update dependencies from their pinned versions. The notebooks tested locally with Python=3.12 as validation in CI runs on Python=3.12.