Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wfc3 notebook dependencies #299

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Conversation

haticekaratay
Copy link
Collaborator

@haticekaratay haticekaratay commented Jul 30, 2024

This PR is to update dependencies from their pinned versions. The notebooks tested locally with Python=3.12 as validation in CI runs on Python=3.12.

@haticekaratay haticekaratay changed the title Update hst-notebook dependencies WIP: Update hst-notebook dependencies Jul 30, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@FDauphin FDauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for working on this 🙌🏾

@haticekaratay haticekaratay requested a review from sosey September 3, 2024 13:51
Copy link
Member

@sosey sosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's just one more pre-requirements file to update

@haticekaratay haticekaratay requested a review from sosey September 4, 2024 13:24
@@ -14,7 +14,7 @@
"\n",
"By the end of this tutorial, you will:\n",
"\n",
"- Download a raw WFC3 image from MAST.\n",
"- Download a raw WFC3 image from MAST. \n",
"- Find the necessary reference files needed for calibration.\n",
"- Edit header keywords.\n",
"- Run `calwf3` `v3.5.2` to calibrate the raw image with the v1.0 pixel based CTE-correction.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instructions need updating for only using hstcal 2.5?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait! my bad, it's been a minute and I forgot calXXX versions don't track hstcal. I see hstcal 2.5 tracking calwf3 at v3.5.2

12-Aug-2020 - MDD - Version 3.5.2

@haticekaratay haticekaratay merged commit c54f2ef into main Sep 4, 2024
22 of 29 checks passed
@haticekaratay haticekaratay deleted the dependency-resolution branch September 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants