-
Notifications
You must be signed in to change notification settings - Fork 23
Update ACS dependencies #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
7d59988
to
c2f5caa
Compare
@sosey, I have conducted a local run of all the notebooks and provided @alyssaguzman with a report detailing the ones requiring updates. The notebooks experiencing failures fail on the main branch and are not caused by these dependency updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haticekaratay it looks like the acs_findsat_mrt_example requirements is installing scipy 1.14 from the scikit-image dependency chain, and that's having issues. Did you ask for the interp to be updated? I see the same failure on main for that notebook.
NotImplementedError: interp2d
has been removed in SciPy 1.14.0.
@sosey @haticekaratay I am in contact with the notebook creator and he's working on updating the code to not use |
Yes, the POC for these notebooks is @alyssaguzman. And I've been in contact with her regarding the notebooks, she is on it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem reasonable. For clarity, I think it's fine to accept the notebook before acstools is updated for the change in scipy, though I think I saw a pr just get accepted for that change. @alyssaguzman is on it and can advise on the timeframe.
This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.