Updated Functions in mast_api_psf Module #335
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
notebooks/WFC3/point_spread_function/hst_point_spread_function.ipynb
Outdated
Show resolved
Hide resolved
notebooks/WFC3/point_spread_function/hst_point_spread_function.ipynb
Outdated
Show resolved
Hide resolved
|
Hi @haticekaratay and @dulude, the CI is giving an exit code 143 error. I am able to run the notebook locally without issue, so please let me know if there are any tests I can complete to track down the source of this issue. Thanks for your time and help! |
|
Hi @gibsongreen and @cshanahan1, this pull request is now passing all CI checks and is ready for review. The changes include minor updates to the text, links, and code in the mast_psf_api module and main notebook. I also folded in @FDauphin 's security updates that were needed to satisfy the new CI security checks. Please let me know if you require any additional information. |
|
Hi @cshanahan1, I see your thumbs up on the above message. Should I go ahead and merge this pull request into main, or would you like to review it in more detail first? I'm not positive I should have merge permission so I wanted to check with you first. Thanks! |
Thanks! I want to pull in @FDauphin before I make these changes as they come directly from his module. Fred, do you foresee these polishing touches causing any issues with the MAST API? I know the query format requirements are very strict and rigid. For the changes you agree with, let me know if I should make them here, or you'd like to make them in your module and I'll pull. |
|
@mrevalski Hey thanks for pulling me in! I just replied to one of @cshanahan1 comments. Everything else is pretty minor and I agree the other comments can be implemented. |
|
Hi @cshanahan1, thank you! I've updated the docstring and addressed and resolved the remaining comments. Ready for merging! |
This request includes minor updates to the mast_api_psf.py module and the corresponding function calls throughout the notebook. These changes were made to match the final version of these functions as they appear in the published version of the download_psf_cutouts.ipynb produced by Fred Dauphin (@FDauphin), which was revised earlier this year.