Update README.md for COS notebooks, added new HASP notebook COSLifetimePositions

[annapayne]

This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

• The title of the notebook in a first-level heading (eg. <h1> or # in markdown).
• A brief description of the notebook.
• A table of contents in an ordered list (1., 2., etc. in Markdown).
• The author(s) and affiliation(s) (if relevant).
• The date first published.
• The date last edited (if relevant).
• A link to the notebook's source(s) (if relevant).

The Rest of the Cells

• There is only one H1 (# in Markdown) used in the notebook.
• The notebook uses other heading tags in order (meaning it does not skip numbers).

Text

• All link text is descriptive. It tells users where they will be taken if they open the link.
• All acronyms are defined at least the first time they are used.
• Field-specific/specialized terms are used when needed, but not excessively.

Code

• Code sections are introduced and explained before they appear in the notebook. This can be fulfilled with a heading in a prior Markdown cell, a sentence preceding it, or a code comment in the code section.
• Code has explanatory comments (if relevant). This is most important for long sections of code.
• If the author has control over the syntax highlighting theme in the notebook, that theme has enough color contrast to be legible.
• Code and code explanations focus on one task at a time. Unless comparison is the point of the notebook, only one method for completing the task is described at a time.

Images

• All images (jpg, png, svgs) have an image description. This could be

  • Alt text (an alt property)
  • Empty alt text for decorative images/images meant to be skipped (an alt attribute with no value)
  • Captions
  • If no other options will work, the image is decribed in surrounding paragraphs.

• Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)

Visualizations

• All visualizations have an image description. Review the previous section, Images, for more information on how to add it.

• Visualization descriptions include

  • The type of visualization (like bar chart, scatter plot, etc.)
  • Title
  • Axis labels and range
  • Key or legend
  • An explanation of the visualization's significance to the notebook (like the trend, an outlier in the data, what the author learned from it, etc.)

• All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.

• All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.

• All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[cshanahan1]

you can run shell commands in the notebook, by making a code cell starting with '!'

i would suggest adding a cell
!swrapper -i cos_data -o cos_products -x, commenting it it out and saying 'uncomment and run cell to do this from the noteboook

[cshanahan1]

this file isn't included in the download instructions

[cshanahan1]

i believe these are notebook outputs that haven't been cleared, can you clear outputs?

[cshanahan1]

this needs to be done programmatically otherwise CI will fail on this notebook. Is there another COS notebook that uses these that you can use as an example?

[cshanahan1]

this cell needs to be reworked - i don't think wrapping it in a try except is the best idea, any error raised will be informative, and the notebook should be written so this doesn't occur anyway. if this is the case of re-running a cell and there are no files to be moved, that can be dealt with in another way.

[cshanahan1]

are these fields in MAST, can this be filtered in the query beforehand rather than deleting the files?

[cshanahan1]

you can also use fits.getdata here to shorten the code, itll handle closing the file

[cshanahan1]

same here, replace with tbdata=fits.getdata so you can remove hdulist and hdulist.close()

[cshanahan1]

you can use getheader here to save a few lines