addressing comments

spacetelescope · Oct 3, 2024 · 4bf36c4 · 4bf36c4
1 parent 5da311a
commit 4bf36c4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jwst/emicorr/emicorr.py b/jwst/emicorr/emicorr.py
@@ -447,7 +447,7 @@ def apply_emicorr(output_model, emicorr_model,
         # Interleave (straight copy) into 4 amps
         noise_x = np.arange(nx4) * 4
         for k in range(4):
-            output_model.data[..., noise_x + k] = output_model.data[..., noise_x + k] - dd_noise
+            output_model.data[..., noise_x + k] -= dd_noise
 
         # clean up
         del data

diff --git a/jwst/emicorr/tests/test_emicorr.py b/jwst/emicorr/tests/test_emicorr.py
@@ -7,7 +7,7 @@
 
 import numpy as np
 from jwst.emicorr import emicorr, emicorr_step
-from stdatamodels.jwst.datamodels import Level1bModel, EmiModel
+from stdatamodels.jwst.datamodels import RampModel, EmiModel
 
 
 subarray_example_case = {
@@ -33,7 +33,7 @@
 
 def mk_data_mdl(data, subarray, readpatt, detector):
     # create input_model
-    input_model = Level1bModel(data=data)
+    input_model = RampModel(data=data)
     input_model.meta.instrument.name = 'MIRI'
     input_model.meta.instrument.detector = detector
     input_model.meta.exposure.type = 'MIR_4QPM'