-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3305: New association candidate type to group mosaic tiles across targets #8798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8798 +/- ##
==========================================
+ Coverage 61.75% 61.77% +0.02%
==========================================
Files 377 377
Lines 38750 38777 +27
==========================================
+ Hits 23931 23956 +25
- Misses 14819 14821 +2 ☔ View full report in Codecov by Sentry. |
Regtest run on associations tests ran here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1725/ I okify'ed prematurely, only to get the files into the truth directory. The value/correctness of the association file will have to be determined independent of a test result here, but the associations utilizing the new rule show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, from a code and documentation perspective.
Started a test run against only sdp_pools here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1732/ |
Resolves JP-3305
Closes #7725
This PR addresses a failure to generate associations for MOSAIC association candidates, due to our level 3 imaging candidates requiring a match on target id. This PR introduces a MOSAIC-candidate-specific class that relaxes the target id constraint, utilizing the filler
t000
identifier introduced by #8528.Tasks
Build 11.3
(use the latest build if not sure)CHANGES.rst
within the relevant release section (otherwise add theno-changelog-entry-needed
label to this PR)docs/
pageokify_regtests
to update the truth files