min pin numexpr #632
Merged
min pin numexpr #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperrin
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
This is reminding me part of why there wasn't previously a pin for this: numexpr had been left as an optional dependency, not strictly required. I think there is no longer any real need for that; it's no hurdle to install. Just inertia that it had been left as an optional dependency only.
It seems clearly better to have it a required dependency and be able to restrict to a known-good version, versus leave as an optional dependency and maybe an unlucky user has the buggy old version. So I'm 👍 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numexpr>=2.9.0 to avoid future bugs per webbpsf issue 902:
spacetelescope/webbpsf#902