RCAL-919: Formalize the patches (sky cells) file (e.g., add it as a reference file) #536
Conversation
perrygreenfield
requested review from
WilliamJamieson and
a team
as code owners
perrygreenfield
force-pushed
the
skycell2
branch
from
1159989 to
e31f792
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage ? 96.61%
=======================================
Files ? 4
Lines ? 266
Branches ? 0
=======================================
Hits ? 257
Misses ? 9
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -306,6 +306,9 @@ def test_ref_file_meta_common(ref_file_schema): | |||
| """ | |||
| all_of = ref_file_schema["properties"]["meta"]["allOf"] | |||
|
|
|||
| if ref_file_schema["id"].find("skycells") >= 0: | |||
There was a problem hiding this comment.
Is this expected to return a negative value at some point? Otherwise it implies the rest of the code would never be run.
There was a problem hiding this comment.
Yes, if the reference file schema is not a skycell schema the value should be -1 and then it should continue on; if it is, it doesn't use the common meta since some of the attributes in that make no sense for this reference file.
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/reference_files/skycells-1.0.0 | ||
|
|
||
| title: Skycells File Schema |
There was a problem hiding this comment.
| title: Skycells File Schema | |
| title: Skycells Reference File Schema |
| @@ -513,4 +513,9 @@ tags: | |||
| title: MSOS Stack Level 3 Schema | |||
| description: |- | |||
| Level 3 schema for SSC's MSOS stack products | |||
| - tag_uri: asdf://stsci.edu/datamodels/roman/tags/reference_files/skycells-1.0.0 | |||
There was a problem hiding this comment.
Could you please move this block to the reference file section?
| @@ -513,4 +513,9 @@ tags: | |||
| title: MSOS Stack Level 3 Schema | |||
| description: |- | |||
| Level 3 schema for SSC's MSOS stack products | |||
| - tag_uri: asdf://stsci.edu/datamodels/roman/tags/reference_files/skycells-1.0.0 | |||
| schema_uri: asdf://stsci.edu/datamodels/roman/schemas/reference_files/skycells-1.0.0 | |||
| title: Schema for the skycell definitions | |||
There was a problem hiding this comment.
This title should match the title within the actual schema file
Resolves RCAL
This PR addresses the need to support the skycell definition file as a reference file.
The schema to support this file has been added to RAD.
This supersedes PR #524 due to my screwups in managing that. I believe it addressed most of the comments made for that.