-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WCS to L2 and L3 models #302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 97.15% 97.19% +0.03%
==========================================
Files 28 29 +1
Lines 2533 2564 +31
==========================================
+ Hits 2461 2492 +31
Misses 72 72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some of the comparison utilities need to be updated to accommodate the GWCS objects. It maybe as simple as updating
roman_datamodels/src/roman_datamodels/testing.py
Lines 57 to 58 in 3b242ed
elif isinstance(value1, Model): | |
assert_model_equal(value1, value2) |
isinstance(value1, (Model, gwcs.<type>))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for more information, see https://pre-commit.ci
Resolves RCAL-749
Closes #1060
This PR addresses ...
Checklist
CHANGES.rst
under the corresponding subsection