Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include required keys #421

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changes/421.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Update RDM maker utils to include the keywords required by a bugfix to RAD that
forces the ``archive_catalog`` and ``sdf`` keywords to be required.
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ dependencies = [
"numpy >=1.22",
"astropy >=5.3.0",
# "rad >= 0.21.0",
"rad @ git+https://github.com/spacetelescope/rad.git",
# "rad @ git+https://github.com/spacetelescope/rad.git",
"rad @ git+https://github.com/WilliamJamieson/rad.git@bugfix/schema_info_required",
"asdf-standard >=1.1.0",
]
dynamic = ["version"]
Expand Down
2 changes: 1 addition & 1 deletion src/roman_datamodels/maker_utils/_common_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def mk_ref_file(**kwargs):
ref_file["inverse_linearity"] = kwargs.get("inverse_linearity", "N/A")
ref_file["photom"] = kwargs.get("photom", "N/A")
ref_file["area"] = kwargs.get("area", "N/A")
ref_file["crds"] = kwargs.get("crds", {"sw_version": "12.3.1", "context_used": "roman_0815.pmap"})
ref_file["crds"] = kwargs.get("crds", {"version": "12.3.1", "context": "roman_0815.pmap"})

return ref_file

Expand Down
1 change: 1 addition & 0 deletions src/roman_datamodels/maker_utils/_fps_common_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ def mk_fps_ref_file(**kwargs):
ref_file["readnoise"] = kwargs.get("readnoise", "N/A")
ref_file["saturation"] = kwargs.get("saturation", "N/A")
ref_file["photom"] = kwargs.get("photom", "N/A")
ref_file["area"] = kwargs.get("area", "N/A")
ref_file["crds"] = kwargs.get("crds", {"sw_version": "12.3.1", "context_used": "roman_0815.pmap"})

return ref_file
1 change: 1 addition & 0 deletions src/roman_datamodels/maker_utils/_tvac_common_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ def mk_tvac_ref_file(**kwargs):
ref_file["readnoise"] = kwargs.get("readnoise", "N/A")
ref_file["saturation"] = kwargs.get("saturation", "N/A")
ref_file["photom"] = kwargs.get("photom", "N/A")
ref_file["area"] = kwargs.get("area", "N/A")
ref_file["crds"] = kwargs.get("crds", {"sw_version": "12.3.1", "context_used": "roman_0815.pmap"})

return ref_file