Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Use numpy 2.x ABI #274

Merged
merged 2 commits into from
Jun 13, 2024
Merged

BLD: Use numpy 2.x ABI #274

merged 2 commits into from
Jun 13, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 15, 2024

BLD: Use numpy 2.x ABI.

DEP: Clean up dependencies and associated docs.

Fix #272

DEP: Clean up dependencies and associated docs.
@pllim pllim added the Build wheels Build wheels on PR label May 15, 2024
@pllim pllim requested a review from jhunkeler May 15, 2024 17:16
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (7da4a41) to head (6e6c264).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files           5        5           
  Lines        1013     1013           
=======================================
  Hits          813      813           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

With this patch, C-ext is now available in devdeps, see https://github.com/spacetelescope/spherical_geometry/actions/runs/9099962846/job/25013742232?pr=274

test_basic.py::test_math_util_inner1d PASSED

@pllim pllim marked this pull request as ready for review May 15, 2024 17:29
@pllim pllim requested a review from a team as a code owner May 15, 2024 17:29
@mcara
Copy link
Member

mcara commented May 15, 2024

Why use a not-yet-released version (of numpy) when building releases?

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

You can wait to merge, no rush on my side. I was just trying to see if this would fix the problem of C-extension not on devdeps and it does.

@mcara
Copy link
Member

mcara commented May 15, 2024

I was just trying to see if this would fix the problem of C-extension not on devdeps and it does.

I know it does. I mentioned this in #265 (comment) and #265 (comment)

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

Ah, sorry if I missed it! I think this diff just need minor tweaks when numpy 2.0 is released.

@mcara
Copy link
Member

mcara commented May 15, 2024

The code was tested to work with C extension build against numpy 2.0.0.dev0 and so if numpy will not make any dramatic changes before an official release - the code will work just fine once numpy 2.0.0 is officially released. If I have to choose between building with an officially release version and not tests devdeps vs building with an experimental version but being able to test with latest alpha/beta numpy, I would prefer the former.

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

if numpy will not make any dramatic changes before an official release

Last I heard, they were debating whether to drop Python 3.9 or not. 😬

Anyways, like I said, you can keep this open for now if you want to wait. I am not asking for you to merge this today.

@zacharyburnett
Copy link
Contributor

sorry, I didn't see this PR before merging #279; this PR will need to be rebased

@mcara mcara merged commit 0f5f0a3 into spacetelescope:master Jun 13, 2024
25 checks passed
@pllim pllim deleted the bld-numpy-2.0 branch June 14, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build wheels Build wheels on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: math_util C-extension refuses to build for numpy 2.x
3 participants