-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Use numpy 2.x ABI #274
Conversation
DEP: Clean up dependencies and associated docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 5 5
Lines 1013 1013
=======================================
Hits 813 813
Misses 200 200 ☔ View full report in Codecov by Sentry. |
With this patch, C-ext is now available in devdeps, see https://github.com/spacetelescope/spherical_geometry/actions/runs/9099962846/job/25013742232?pr=274
|
Why use a not-yet-released version (of numpy) when building releases? |
You can wait to merge, no rush on my side. I was just trying to see if this would fix the problem of C-extension not on |
I know it does. I mentioned this in #265 (comment) and #265 (comment) |
Ah, sorry if I missed it! I think this diff just need minor tweaks when numpy 2.0 is released. |
The code was tested to work with C extension build against numpy 2.0.0.dev0 and so if numpy will not make any dramatic changes before an official release - the code will work just fine once numpy 2.0.0 is officially released. If I have to choose between building with an officially release version and not tests devdeps vs building with an experimental version but being able to test with latest alpha/beta numpy, I would prefer the former. |
Last I heard, they were debating whether to drop Python 3.9 or not. 😬 Anyways, like I said, you can keep this open for now if you want to wait. I am not asking for you to merge this today. |
sorry, I didn't see this PR before merging #279; this PR will need to be rebased |
BLD: Use numpy 2.x ABI.
DEP: Clean up dependencies and associated docs.
Fix #272