Add setting of number_extended_events #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not being set when in single processing mode.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 74.46% 74.41% -0.06%
==========================================
Files 29 29
Lines 5937 5944 +7
==========================================
+ Hits 4421 4423 +2
- Misses 1516 1521 +5
☔ View full report in Codecov by Sentry. |
kmacdonald-stsci
approved these changes
Jul 6, 2023
hbushouse
reviewed
Jul 6, 2023
|
Don't understand why the one pytest that was unskipped is causing failures in the CI tests (claims it can't find the input data file, which is clearly present in the data directory), but runs fine when I test it locally. So just to get the CI tests to work I marked it to be skipped again. |
|
@ddavis-stsci Can you please review for Roman? |
hbushouse
approved these changes
Jul 7, 2023
ddavis-stsci
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM, this should be skipped for romancal and romancal regression tests pass with this update.
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/273/
|
OK, it looks like we're all in agreement. Merging now. |
mairanteodoro
pushed a commit
to mairanteodoro/stcal
that referenced
this pull request
Jul 10, 2023
* Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
mairanteodoro
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
nden
added a commit
that referenced
this pull request
Aug 2, 2023
* Add methods necessary for resample. * Small changes to accommodate both JWST and RST datamodels. * Add CHANGES.rst entry. * Add PR number to CHANGES.rst entry. * use protocols * temp * add dependencies * add CI testing to alignment branch * add CI testing to alignment branch * fix test * Add setting of number_extended_events (#178) * Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu> * Rename variables with FITS keywords names. * Style reformating. * Update docs to include stcal.alignment. * Revert "Rename variables with FITS keywords names." This reverts commit 0eea0e5. * Updates to address most comments. * Fix misplaced comment. * Code refactoring and additional unit test. * Silencing style check warning F403. * Small style refactoring. * Set minimum asdf version. * Update matplotlib's inventory URL. * Set lower version for gwcs. * Bump astropy version to >= 5.1. * Fix docs style issues. * Style check fix. * Fix issue with bounding boxes in tests. * Fix issue with bounding boxes in tests. --------- Co-authored-by: Nadia Dencheva <nadia.dencheva@gmail.com> Co-authored-by: mwregan2 <mregan@stsci.edu> Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
mairanteodoro
added a commit
that referenced
this pull request
Aug 22, 2023
* Add methods necessary for resample. * Small changes to accommodate both JWST and RST datamodels. * Add CHANGES.rst entry. * Add PR number to CHANGES.rst entry. * use protocols * temp * add dependencies * add CI testing to alignment branch * add CI testing to alignment branch * fix test * Add setting of number_extended_events (#178) * Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu> * Rename variables with FITS keywords names. * Style reformating. * Update docs to include stcal.alignment. * Revert "Rename variables with FITS keywords names." This reverts commit 0eea0e5. * Updates to address most comments. * Fix misplaced comment. * Code refactoring and additional unit test. * Silencing style check warning F403. * Small style refactoring. * Set minimum asdf version. * Update matplotlib's inventory URL. * Set lower version for gwcs. * Bump astropy version to >= 5.1. * Fix docs style issues. * Style check fix. * Fix issue with bounding boxes in tests. * Fix issue with bounding boxes in tests. * Add new methods required by resample_step. * Small refactoring and clean ups. * RCAL-632: add unit tests for new methods. * Fix style check errors. * Set sphinx version for compatibility with sphinx-rtd-theme. * Fix style issues. * Revert reproject commit. --------- Co-authored-by: Nadia Dencheva <nadia.dencheva@gmail.com> Co-authored-by: mwregan2 <mregan@stsci.edu> Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
mairanteodoro
added a commit
that referenced
this pull request
Aug 23, 2023
* Add methods necessary for resample. * Small changes to accommodate both JWST and RST datamodels. * Add CHANGES.rst entry. * Add PR number to CHANGES.rst entry. * use protocols * temp * add dependencies * add CI testing to alignment branch * add CI testing to alignment branch * fix test * Add setting of number_extended_events (#178) * Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu> * Rename variables with FITS keywords names. * Style reformating. * Update docs to include stcal.alignment. * Revert "Rename variables with FITS keywords names." This reverts commit 0eea0e5. * Updates to address most comments. * Fix misplaced comment. * Code refactoring and additional unit test. * Silencing style check warning F403. * Small style refactoring. * Set minimum asdf version. * Update matplotlib's inventory URL. * Set lower version for gwcs. * Bump astropy version to >= 5.1. * Fix docs style issues. * Style check fix. * Fix issue with bounding boxes in tests. * Fix issue with bounding boxes in tests. * Add new methods required by resample_step. * Small refactoring and clean ups. * RCAL-632: add unit tests for new methods. * Fix style check errors. * Set sphinx version for compatibility with sphinx-rtd-theme. * Fix style issues. * Revert reproject commit. * Small changes to accommodate both JWST and RST datamodels. * fix test * Rename variables with FITS keywords names. * Revert "Rename variables with FITS keywords names." This reverts commit 0eea0e5. * Code refactoring and additional unit test. * Bump astropy version to >= 5.1. * Fix docs style issues. * Small refactoring and clean ups. * Fix style issues. * Revert reproject commit. * Revert "Revert reproject commit." This reverts commit 9ac8694. * Fix issue caused by bad conflict resolution. * Fix duplicate code. --------- Co-authored-by: Nadia Dencheva <nadia.dencheva@gmail.com> Co-authored-by: mwregan2 <mregan@stsci.edu> Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to JP-3096
This PR fixes the population of the new EXTNCRS keyword, which was not being set when in single processing mode.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)