Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize tests, make devdeps testing optional, and unpin latest Python testing #213

Merged
merged 18 commits into from
Dec 11, 2023

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-79

This PR reorganizes CI tests and moves devdeps tests to a new optional workflow that can be started with the label run devdeps tests

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5756fda) 84.31% compared to head (08d6710) 84.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          35       35           
  Lines        6452     6452           
=======================================
  Hits         5440     5440           
  Misses       1012     1012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cron.yml Outdated Show resolved Hide resolved
.github/workflows/tests_devdeps.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the files listed a master branch, but STCAL uses a main branch. Is the use of master in this PR correct?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/tests_devdeps.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci_cron.yml Show resolved Hide resolved
@zacharyburnett zacharyburnett mentioned this pull request Sep 19, 2023
5 tasks
.github/workflows/ci_cron.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cron.yml Outdated Show resolved Hide resolved
.github/workflows/tests_devdeps.yml Outdated Show resolved Hide resolved
.github/workflows/tests_devdeps.yml Outdated Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

github doesn't want to let me create a review, despite the fact that I've been tagged as a reviewer.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse
Copy link
Collaborator

github doesn't want to let me create a review, despite the fact that I've been tagged as a reviewer.

Nevermind, it suddenly decided to let me review again.

@zacharyburnett zacharyburnett merged commit d71cb6d into spacetelescope:main Dec 11, 2023
26 of 30 checks passed
@zacharyburnett zacharyburnett deleted the ci/separate_devdeps branch December 11, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants