Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3583: Long integrations truncation in ramp fitting #251

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

mwregan2
Copy link
Collaborator

@mwregan2 mwregan2 commented Mar 20, 2024

Resolves JP-3583

Closes spacetelescope/jwst#8373

This PR addresses an issue in the ramp_fitting routine where when finding the cosmic ray free segments of integrations. The code accumulates the non-CR groups using a counter. The problem is that this counter is a uint8 data type. Thus, once we get above 256 groups, it rolls over leading to only using a subset of the groups in the slope fit.

The solution was to change three variables from UINT8 to UINT16. This is big enough given the overall limit on the number of frames.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.18%. Comparing base (41259f3) to head (f618519).
Report is 9 commits behind head on main.

Files Patch % Lines
tests/test_ramp_fitting.py 81.81% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   85.90%   85.18%   -0.73%     
==========================================
  Files          35       35              
  Lines        6557     6797     +240     
==========================================
+ Hits         5633     5790     +157     
- Misses        924     1007      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse changed the title Long integrations truncation JP-3583: Long integrations truncation in ramp fitting Mar 20, 2024
CHANGES.rst Outdated Show resolved Hide resolved
@hbushouse hbushouse merged commit 72de44e into spacetelescope:main Mar 21, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ramp Fitting Errors for Integrations with more than 256 Groups
2 participants