Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-155] build with Numpy 2.0 release candidate #260

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented May 31, 2024

resolves SCSB-155

Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as 1.26

this PR pins numpy>=2.0.0rc2 in build-system.requires

Note

this PR was generated automatically by batchpr 🤖

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this May 31, 2024
@zacharyburnett zacharyburnett changed the title pin numpy>=2.0.0rc2 in build-system.requires [SCSB-155] build with Numpy 2.0 release candidate May 31, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (af5aefb) to head (b16a9e7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   85.18%   83.73%   -1.46%     
==========================================
  Files          35       35              
  Lines        6797     6990     +193     
==========================================
+ Hits         5790     5853      +63     
- Misses       1007     1137     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator

Thanks for opening this PR! @zacharyburnett I pushed a change to this PR renaming the now missing NPY_NTYPES to NPY_NTYPES_LEGACY in a debugging function. I believe this is the only change required to build with numpy 2.0 (the CI now passes, checking locally it works). Would you add a changelog to this PR and queue up regression tests (I think just making sure it works with runtime numpy <2.0 makes sense as other dependencies will need to be updated for runtime numpy >=2.0)?

@zacharyburnett
Copy link
Collaborator Author

JWST regtest running against this branch at https://github.com/spacetelescope/RegressionTests/actions/runs/9350842575/job/25735604033

@braingram
Copy link
Collaborator

braingram commented Jun 3, 2024

I started roman regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/803/
All ran without errors with this PR and numpy 1.26.4

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Jun 3, 2024

the GHA JWST test had some errors, but I'm not sure if those are due to unresolved issues in the GHA or this PR, so I ran on Jenkins here: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2913/pipeline

@zacharyburnett
Copy link
Collaborator Author

@braingram
Copy link
Collaborator

I don't think so. They match the ones from the previous run (which used stcal main):
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2912/tests

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacharyburnett zacharyburnett marked this pull request as ready for review June 3, 2024 17:52
@zacharyburnett zacharyburnett requested a review from a team as a code owner June 3, 2024 17:52
@zacharyburnett zacharyburnett merged commit f90880d into spacetelescope:main Jun 3, 2024
22 of 24 checks passed
@zacharyburnett zacharyburnett deleted the pin_numpy_build_requirement branch June 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants